maintenance: anonymise the named science target in the WFC3-IR hole regression - #74
Merged
Merged
Conversation
…egression Library repos must not name science targets. The WFC3-IR mosaic-hole regression is now identified by the dataset shape it encodes (HST program 14653, F160W, five-exposure mosaic, a 123-px hole at r = 5.3") rather than by the target it was found on. - autoreduce/instruments/wfc3_ir.py: reword the dq_bits_rows rationale comment. - test_autoreduce/test_target_and_instruments.py: rename test_pj011646_would_not_have_holed -> test_five_exposure_f160w_mosaic_would_not_have_holed and reword its comment; assertions untouched. - docs/design/wfc3.md: reword the "Blobs (DQ 512)" paragraph so the failing dataset is identified generically. Comment, test-name and doc text only - no behaviour change, no API change. Refs #73 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GZceRRca9F5ojAtjpRp3me
This was referenced Aug 29, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Library repos must not name science targets. The WFC3-IR mosaic-hole regression
— the reason the IR adapter ships STScI's MDRIZTAB
dq_bits_rowsinstead ofdrizzlepac's
final_bits = "0"default — was named after the real target it wasfound on. It is now identified by the dataset shape it actually encodes: HST
program 14653, F160W, a five-exposure mosaic with a 123-px hole at r = 5.3".
Three sites: the adapter's rationale comment, the regression test's name and
comment, and the "Blobs (DQ 512)" paragraph of the WFC3 design note.
API Changes
None — internal changes only. The renamed identifier is a pytest method
referenced nowhere outside its own file; no exported symbol, signature, default
or behaviour changes.
Test Plan
python3 -m pytest test_autoreduce/ -q→ 299 passed, 3 skippedgrep -rIn -i pj011646 --exclude-dir=.gitreturns nothing trackedGenerated by the PyAutoLabs agent workflow.