Repository navigation
feat: validate optional organs before connecting a Scientist - #72
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connecting an optional organ previously required editing the instance profile directly, even if its feed was missing or belonged to another organ. The new CLI previews and validates the explicit connection before saving, refuses mismatches/conflicts, and makes repeated identical setup harmless.
Scripts Changed
scripts/connect_organ.py: reuse canonical identity, instance/project and shared state validation; atomic profile-only apply with detected-input-change protection and permission preservation.tests/test_connect_organ.py: Broca connection, failure/retry/no-op, independent names, existing records/connections, invalid feeds/choices, changed inputs, symlinks and replace failures.STARTER.md: commands and AI resume prompt, with connection versus readiness/provisioning boundaries.Validation
state.jsonreturns 404. The CLI refused connection and preserved the synthetic profile. This is a missing owner-feed prerequisite, not a successful live activation; the next Broca task is recorded in Mind.release validation incomplete: no rehearsal for current source; no RED/YELLOW. No release.This slice connects an already prepared public organ. It does not provision/deploy organs, fabricate owner evidence, copy project source or add a new lifecycle ledger. Input checks detect changes during validation; avoid concurrent manual edits during apply. Current feed health/freshness remains with its owner.
Closes #71. Epic: scientist-adoption-pilot. Tier: judge; human /prm.