Skip to content

Remove forced horizontal scrolling from starter cockpit #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jammy2211 merged 1 commit into from
Oct 13, 2026
Merged

Remove forced horizontal scrolling from starter cockpit #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions scripts/instance_navigation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,10 +88,7 @@ def render(instance):
.cockpit-idle{border:1px solid var(--shell-line);border-radius:8px;background:var(--shell-alt);color:var(--shell-soft);min-height:44px;padding:.35rem .65rem;font-family:inherit;font-size:.78rem;font-weight:700;letter-spacing:.04em;white-space:nowrap;opacity:.7}
.cockpit-idle span{color:var(--shell-grey);margin-right:.35em}
.instance-nav{background:var(--shell-alt);border-bottom:1px solid var(--shell-line)}
.instance-nav .nav-scroll{max-width:1160px;margin:auto;overflow-x:scroll;overscroll-behavior-x:contain;scrollbar-width:thin;scrollbar-color:var(--shell-grey) var(--shell-alt);padding:.45rem .5rem;box-sizing:border-box}
.instance-nav .nav-scroll::-webkit-scrollbar{height:8px}
.instance-nav .nav-scroll::-webkit-scrollbar-track{background:var(--shell-alt)}
.instance-nav .nav-scroll::-webkit-scrollbar-thumb{background:var(--shell-grey);border-radius:4px}
.instance-nav .nav-scroll{overflow-x:auto;overscroll-behavior-x:contain;scrollbar-width:thin;padding:.45rem .5rem;box-sizing:border-box}
.instance-nav ul{display:flex;gap:.3rem;list-style:none;width:max-content;margin:0 auto;padding:0}
.instance-nav .board-link{display:flex;flex-direction:column;align-items:center;justify-content:center;gap:.15rem;min-width:76px;min-height:64px;padding:.4rem .65rem;border:1px solid transparent;border-radius:12px;color:var(--shell-soft);font-size:.8rem;font-weight:650;text-decoration:none;box-sizing:border-box}
.instance-nav .board-link:hover{background:var(--shell-bg);color:var(--shell-text)}
Expand Down
7 changes: 4 additions & 3 deletions tests/navigation_browser.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,10 @@ const assert = require('node:assert/strict');
assert.equal((await page.locator('.cockpit-home').innerText()).replace(/\s+/g,' '),'MyScientist / Cockpit');
assert.equal(await page.locator('.cockpit-idle').isDisabled(),true);
assert.equal(await page.locator('#cockpit-heading').textContent(),'Scientist');
assert(await page.locator('.nav-scroll').evaluate(el=>el.scrollWidth>el.clientWidth));
assert.equal(await page.locator('.nav-hint').isVisible(),true);
assert.equal(await page.locator('.nav-scroll').evaluate(el=>getComputedStyle(el).overflowX),'scroll');
const overflows=await page.locator('.nav-scroll').evaluate(el=>el.scrollWidth>el.clientWidth);
assert.equal(overflows,width<1440);
assert.equal(await page.locator('.nav-hint').isVisible(),overflows);
assert.equal(await page.locator('.nav-scroll').evaluate(el=>getComputedStyle(el).overflowX),'auto');
const initialToolbar=await page.locator('.cockpit-toolbar').boundingBox();
await page.locator('#scientist').evaluate(el=>el.scrollTop=500);
assert.equal((await page.locator('.cockpit-toolbar').boundingBox()).y,initialToolbar.y);
Expand Down
Loading