Repository navigation
test: add integration scripts for SMC, Drawer, BFGS, MultiStartADABelief, MultiStartLion (search-extensibility A0c) - #108
Merged
Conversation
It named PyAutoLens and listed mcmc/nest/mle.yaml, which no longer exist. Only GridSearch.yaml lives here; per-search defaults are constructor arguments (PyAutoFit #1202). Refs PyAutoLabs/PyAutoFit#1668 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…ief, MultiStartLion Five exported searches had no integration script. Each new script fits the 1D Gaussian dataset and asserts truth recovery (Drawer: valid best draw and the requested number of draws). Under PYAUTO_TEST_MODE only the wiring is checked, since test mode cuts the schedules short. The JAX searches declare `ENV: real_search jax` like BlackJAXNUTS.py / MultiStartAdam.py. Drawer.py writes to output/searches/Drawer rather than using NullPaths: Drawer._fit reads self.timer.time, which is None under NullPaths. Run on demand; not added to smoke_tests.txt. Refs PyAutoLabs/PyAutoFit#1668 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
2 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Search-extensibility A0c part 1 (PyAutoFit#1668): executable integration scripts for the five searches that had none, modelled on
BlackJAXNUTS.py/LBFGS.py/MultiStartAdam.py. Run on demand; deliberately not added tosmoke_tests.txt. Truth-recovery asserts run only outside test mode (test mode cuts SMC to 16 particles and 5 steps). The JAX scripts declareENV: real_search jax.Drawer.pywrites tooutput/searches/Drawerinstead of using NullPaths becauseDrawer._fitreadsself.timer.time(drawer/search.py:147) and the timer isNoneunder NullPaths. That is a library bug, filed separately; the script says why.Scripts Changed
scripts/searches/SMC.py— newscripts/searches/Drawer.py— newscripts/searches/BFGS.py— newscripts/searches/MultiStartADABelief.py— newscripts/searches/MultiStartLion.py— newUpstream PR
PyAutoLabs/PyAutoFit#1669
Test Plan
PYAUTO_TEST_MODE=1: 5/5 passGenerated by the PyAutoLabs agent workflow.
🤖 Generated with Claude Code