Repository navigation
docs: design independent HST MGE pilot qualification - #418
Merged
Merged
Conversation
This was referenced Oct 13, 2026
Contributor
Author
Review 2026-10-17 — FINDINGS (none blocking a doc-only merge)Independent read of Open questions vs the design:
Findings:
Branch is 30 commits behind main but touches only |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The raw HST/MGE pilot can measure execution but has no independent scientific correctness witness. Document the exact calculation to qualify, the proposed independent reference and the decisions required before collection.
The audit distinguishes the stabilized non-negative reconstruction from the reported Gaussian data likelihood: the diagonal stabilization affects the coefficients but contributes no extra likelihood term for these unregularized bases. It proposes independently constructed imaging columns and an augmented NNLS reference, with explicit shared-code limitations, artifact identity, comparison metrics and unaccepted tolerance candidates. It also records the small-dataset environment/count mismatch as a follow-up guard requirement.
Closes #417. This completes the approved qualification-design phase only. Coefficient thresholds, executable witness validation, production context and collection approval remain pending. No inference, numerical reference solve or production profiling ran.
Scripts Changed
scripts/misc/jax_compile/QUALIFICATION.md: source-pinned audit, reference design and decision table.scripts/misc/jax_compile/PILOT.md: link to the design.No executable scripts, tests, defaults, measurements or generated timing metadata changed.
Test Plan
release validation incomplete: no rehearsal for current source; development publication permitted, no release.Tier: judge — human
/prm. The numerical thresholds in this document are proposals for review, not accepted scientific criteria.