Repository navigation
fix: lint red after PyAutoArray#634 — re-pin abstract.py anchors, probe shared-Cholesky route - #424
Merged
Merged
Conversation
…fter PyAutoArray#634 (#423) PyAutoArray#634 (02aa2e48) inserted 81 lines in inversion/abstract.py and routes the NumPy positivity-off solve through a shared Cholesky factor. Re-pin every xla_attribution abstract.py anchor (AST + difflib between 02aa2e48^ and 02aa2e48, anchored content identical) and make positive_negative_probe count both route-(c) paths (lu_solve, shared_cholesky; calls = their sum). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 16, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
autolens_profiling lint goes red against PyAutoArray main since PyAutoArray#634 (
02aa2e48); seen on PR #422 (run 38883395602, 2 of 1456 tests). This re-pins theabstract.pyanchors and makes the positive-negative probe see the new shared-Cholesky route.Closes #423
Scripts Changed
scripts/misc/likelihood_breakdown/xla_attribution.py:LIBRARY_ANCHOR_REVISION→ 02aa2e48. Re-pinned_ABSTRACT_LOG_DET_BODY(969,1013)→(1037,1081),_CURVATURE_CALLER(1015,1096)→(1083,1177),_REGULARIZATION_CALLER(1116,1177)→(1197,1258),regularization_term(903,967)→(971,1035),mapped_reconstruction(832,902)→(900,970), secondreconstruction_scatter(714,830)→(714,898). Shifts come from difflib between02aa2e48^and02aa2e48, and every anchored line is text-identical. Anchors above line 763 are unchanged.reconstruction_scatterand the curvature caller) now enclose new #634 code. They follow the function body as the AST requires, and the new branch is NumPy-only (the factor isNoneon JAX), so it never appears in an XLA trace.scripts/misc/likelihood_breakdown/library_solver_injection.py:positive_negative_probealso wrapsscipy.linalg.cho_solvefor the context. It counts only calls made directly fromAbstractInversion.reconstruction. Counts are now{calls, lu_solve, shared_cholesky}withcalls= their sum. The citation abstract.py:540 is corrected to 568-569.scripts/imaging/pixelized/fixed_light_library.py: records which route-(c) path ran (two new JSON keys), androute_verifiednames the path.scripts/misc/test/test_fixed_light_library.py,test_xla_attribution.py: fixture lines follow the anchors. New test: the probe is silent on the positive-only route and restores both patched functions.Validation
Heart RED override (development only), AUTONOMY.md "Human override for Heart RED (development only)"
pyauto-heart readiness --json): "PyAutoFit: 1 commit(s) behind origin"; "PyAutoGalaxy: 1 commit(s) behind origin"; "PyAutoLens: 1 commit(s) behind origin"; "release validation incomplete: no rehearsal for current source"pytest scripts/misc/test/1457 passed / 6 skipped / 0 failed against PyAutoArray e59d5fa9 (contains #634);ruff check .andruff format --check .clean; architect review of the probe + anchor diff🤖 Generated with Claude Code