Repository navigation
render: point positions panels (PyAutoLens#786) - #11
Merged
Merged
Conversation
…uals, curves (PyAutoLens#786) Re-render point_source_image_chi_squared, point_source_source_chi_squared and cluster against PyAutoLens#786. The cluster producer passes the solver to dataset_point and lets fit_point compute the critical curves the "Fit Positions" panel now draws (~2 min per dataset). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Re-renders the point-source and cluster figures against the new positions panels of PyAutoLens#786 (issue PyAutoLabs/PyAutoLens#785).
dataset.png:Dataset Positions (point_0)over the PointSolver grid extent (±2.5″ for the point example, ±40″ for the cluster), no axis labels, large filled markers, σ in the legend (Observed (σ = 0.005″)). The 0.005″ noise circles are drawn at true radius, so they are sub-pixel at this extent.fit.png:Fit Positions (point_0)adds model positions (red crosses), residual lines from the fit's own pairing (image-plane chi-squared only, so the true model gives sub-pixel lines), unmatched model images (none for the true model), whole critical curves (thin grey tangential, olive radial) and the mass-profile centres (green+). The source-plane chi-squared fit showsModel (source plane)and no residual lines.solver=analysis.solvertoPlotterPoint.dataset_pointand no longer passes empty curve lists tofit_point, so the fit panel draws the critical curves like the visualizer does. This adds ~2 min per point dataset (~4.5 min for the producer) to the render.AGENTS.mdand the producer docstring are updated to match.Scripts Changed
scripts/cluster/visualization.py: passes the solver todataset_point; critical curves now computed byfit_point; docstring updated.AGENTS.md: cluster note updated (the fit panel draws curves now).point_source_image_chi_squared,point_source_source_chi_squared,cluster(dataset.png,fit.png);gallery/viz_manifest.yaml.Upstream PR
lintCI renders the producers against the library mains, so it stays red (PNG/manifest drift) until #786 merges; re-run it after that.Test Plan
ruff check .,ruff format --check .,python gallery/gallery_build.py --checkandpytest scripts/misc/testpass locally (17 passed).lintgreen after PyAutoLens#786 merges.Heart readiness at ship: YELLOW, pre-existing and unrelated, acknowledged by the human ("manifest drift: workspace checkouts — 1 mismatch vs PyAutoMind/repos.yaml"; "release validation stale: source moved since rehearsal (PyAutoArray)").
Generated by the PyAutoLabs agent workflow.
🤖 Generated with Claude Code