Repository navigation
render: PointSolver refinement figure + thinner model cross - #12
Merged
Merged
Conversation
…ns#788) - point_source_image_chi_squared: visualize(quick_update=False) keeps point_solver.png (the model's real solver, steps 0/1/2/final); teaching/point_solver.png + point_solver.gif from aplt.plot_point_solver on a coarse 11x11 @ 0.5" grid. - cluster: PlotterPoint.point_solver per plane -> point_<i>/point_solver.png; critical curves computed once per dataset and shared with fit_point (as VisualizerPoint does). - config/visualize/plots.yaml: fit_point_dataset: subplot_point_solver: true. - Re-rendered point_source_* and cluster fit.png (thinner model cross). - _viz_cli.mirror_to_scratch also mirrors GIFs; the PNG manifest/GALLERY.md are unchanged in shape (the GIF is tracked beside its still, not a manifest entry). Docs updated. Refs PyAutoLabs/PyAutoLens#787 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…yAutoLens#788) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Renders the new PointSolver refinement figure (PyAutoLens#788, issue PyAutoLabs/PyAutoLens#787) and re-renders the point and cluster
fit.pngs with the thinner model ✕.point_solver.pngfor point_source_image_chi_squared and for each cluster plane (point_0,point_1). It shows steps 0, 1, 2 and final of the model's own solver. On these fine grids, steps 1, 2 and final look alike (sub-pixel triangles drawn as ▲), which the human accepted.point_source_image_chi_squared/images/visualization/teaching/point_solver.pngpluspoint_solver.gif, rendered byaplt.plot_point_solveron a coarse 11×11 @ 0.5″ grid (precision 0.01″). It is the approvedvariant_f_coarselook with arc-second ticks. The GIF has 4 frames (0, 1, 2, final) at 640×730, 1.25 s each with the final frame held 3.75 s, loops, and is about 0.13 MB.teaching/sub-folder of that domain rather than a new pseudo-domain. The repo's rule is one folder per dataset type.gallery/viz_manifest.yamlandGALLERY.mdlist PNGs only (the PyAutoEyes read contract), so the GIF is tracked beside its PNG still but is not a manifest entry. The builder is unchanged.render.ymlalreadygit add -Asscripts/*/images, so release re-renders commit it._viz_cli.mirror_to_scratchnow also mirrors GIFs to the Eyes scratch.config/visualize/plots.yamlsetsfit_point_dataset: subplot_point_solver: true. It is off by default in the library.Scripts Changed
scripts/point_source_image_chi_squared/visualization.py:visualize(quick_update=False)so the visualizer writespoint_solver.png(kept); adds the teaching still and GIF.scripts/cluster/visualization.py: computes the critical curves once per dataset, passes them tofit_point, and addsPlotterPoint.point_solver; keepspoint_solver.png._viz_cli.py: the scratch mirror copies*.giftoo.config/visualize/plots.yaml,AGENTS.md,README.md,GALLERY.md,gallery/viz_manifest.yaml(68 → 72 PNGs).point_source_image_chi_squared:fit.png,point_solver.png,teaching/*point_source_source_chi_squared:fit.pngcluster:point_{0,1}/{fit,point_solver}.pngUpstream PR
PyAutoLabs/PyAutoLens#788
Test Plan
ruff check .andruff format --check .are clean;gallery_build.py --checkis current;pytest scripts/misc/test: 17 passed.lintis expected RED until PyAutoLens#788 merges. Its producers run against the library mains, wherePlotterPoint.point_solverandaplt.plot_point_solverdon't exist yet. Re-run after the library merge (library-first).Generated by the PyAutoLabs agent workflow.
🤖 Generated with Claude Code