Repository navigation
Correct stale source-plane xp-blocker claims in jax_profiling (#657) - #121
Merged
Merged
Conversation
…#657 phase 2 fixed it)
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prose-only correction: the point-source source-plane jax_profiling scripts still claimed the forward JIT is blocked by the
Grid2DIrregular.grid_2d_via_deflection_grid_fromxp-propagation bug. That bug was fixed in PyAutoLens#657 phase 2 (PyAutoArray#414, merged 2026-07-27) — the source-plane likelihood now JITs cleanly. The remaining gap is the whole-fit-objectjax.jit(analysis.fit_from)case (PointSolver leaf in the returned pytree), tracked in PyAutoPrompt/autolens/fit_point_pytree.md. No control flow changed.Scripts Changed
jax_profiling/jit/point_source/source_plane.py— PART B header no longer "expected to fail"; PART C reframed as isolating the ray-trace prefix (note: thetry/except TracerArrayConversionErrorat lines ~239-256 is now likely dead code — left untouched deliberately, prose-only PR)jax_profiling/gradient/point_source/source_plane.py— "Surprising finding" docstring rewritten (both forward-JIT and gradient paths work); Step 1 and PART C comments updatedjax_profiling/jit/point_source/image_plane.py— removed the false "unlike the source-plane variant" contrastjax_profiling/gradient/README.md— stale "still blocked" table cell correctedUpstream PR
PyAutoLabs/PyAutoLens#659 (merged 2026-07-27).
Test Plan
Generated by the PyAutoLabs agent workflow.