Repository navigation
cloud workspace: clone MicroPython at micropython-pydevices' pinned commit - #112
Merged
Merged
Conversation
…ommit micropython-pydevices pins MicroPython by full commit, which clone --branch can't take, so the interpreter checkout failed. A commit is now fetched on its own. The pin is read from DEPENDENCIES.lock, where micropython-pydevices is moving it, or UPSTREAM before that. ulab's stack row points at micropython-pydevices' modules page, which exists before and after the move, in place of modules.lock.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cloud workspace installer clones MicroPython at the commit micropython-pydevices pins. That pin is a full 40-character commit, and
git clone --branchtakes only branches and tags, so the clone failed. A full commit is now fetched on its own at depth 1; a tag or branch still goes throughclone --branch. The pin is read from micropython-pydevices'DEPENDENCIES.lock, which is replacingUPSTREAM,modules.lockanddeps.lockthere, and fromUPSTREAMin a checkout from before that;PYDEVICES_MP_TAGstill overrides both.ulab's row in
data/stack.jsonpointed at micropython-pydevices'modules.lock, which goes away with that change, and the stack check fails on a path that's gone. It now points atdocs/reference/modules.md, which says where ulab comes from and exists before and after. The row's link on the page is ulab's upstream repository either way.I ran the installer's
mp_pinandshallow_clone_if_missingon their own: against a checkout withDEPENDENCIES.lock, one with onlyUPSTREAM, and none, they print the same commit, the same commit andv1.29.0, and the commit clone lands at that commit.stack.py --check --stalereports 159 rows and no problems. The whole installer wasn't run in a cloud container.