Repository navigation
Conversation
The template fetched pydevices v0.7.0, so it missed the multimer dispatch and Web Audio fixes in v0.7.9. pyscript.json now reads every file from v0.7.9. psdisplay there imports displaydev/_webcanvas.py and _webinput.py, and the Web Audio module imports audiodev/bytequeue.py, so all three are added to the file list. I served the page in Playwright's Chromium: PyScript starts, the status line reads "Running displaydev in Pyodide. Click the canvas to paint.", the three new files and psdisplay are fetched from v0.7.9, and nothing is requested from v0.7.0. The unit tests pass with the URL check moved to v0.7.9.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The template fetched pydevices v0.7.0, so it missed the multimer dispatch and Web Audio fixes in v0.7.9. pyscript.json now reads every file from v0.7.9. psdisplay there imports displaydev/_webcanvas.py and _webinput.py, and the Web Audio module imports audiodev/bytequeue.py, so all three are added to the file list.
I served the page in Playwright's Chromium: PyScript starts, the status line reads "Running displaydev in Pyodide. Click the canvas to paint.", the three new files and psdisplay are fetched from v0.7.9, and nothing is requested from v0.7.0. The unit tests pass with the URL check moved to v0.7.9.