Repository navigation
appkit: run() starts the folder's own home app when it has one - #42
Merged
Merged
Conversation
appkit.run() with no name scanned the apps folder and then registered appkit.home under the name home, replacing a scanned apps/home. A board whose apps folder holds the tabbed Home got appkit's plain column of buttons. run() now registers appkit.home only when the folder has no home. A new launcher check scans a sample folder with a home app and one without: the first keeps apps.home, the second gets appkit.home. With the old rule planted it fails on CPython and unix MicroPython; with this change all 17 checks pass on both.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
appkit.run()with no name scanned the apps folder and then registeredappkit.homeunder the namehome, which replaced a scannedapps/home. A board whoseapps/holds this repository's tabbed Home got appkit's plain column of buttons instead. Nowrun()keeps a scannedhomeapp and falls back toappkit.homeonly when the folder has none. The appkit README says so in one line.A new launcher check,
run_keeps_a_scanned_home, scans a sample folder that has ahomeapp and one that doesn't: the first keepsapps.home, the second getsappkit.home. With the old rule planted it fails on CPython and on unix MicroPython; with the change all 17 launcher checks pass on both. I also ranappkit.run()on desktop CPython (SDL, dummy video) against this repository's realapps/folder: before the change the home screen wasappkit.homewith 22 widgets on screen, after itapps.home.run()still uses appkit's plainLauncherandShell, so the tabbed Home started this way has appkit's corner Home button rather than touchkit's header and BOOT button; a board that wants those still builds aTouchLauncherandTouchShellitself. I didn't run it on a board.Fixes #38