Repository navigation
Programs: Ostinato and Vamp move to programs/, apps/ keeps Home apps - #58
Merged
Merged
Conversation
Things that run on their own now live in programs/, each with a README that says what it runs on and how to put it there. apps/ holds only Home apps, and a test fails if one lacks an app.json. Ostinato's README and the docs name the apps repo instead of the old studio name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ostinato and Vamp move from apps/ to programs/ with git mv. A program runs on its own; a Home app, with an app.json, stays in apps/. programs/README.md lists the programs and says what each program folder carries: a README that opens with what it does, then a Runs on line, then how to put it there. Vamp gets one.
Every path to the old locations is fixed: the guides, tools/vamp_files.py and vamp_link_check.py, the Vamp tests, the CI workflow, the style exclude list and the READMEs. The old "studio" name is replaced by the apps repo in Ostinato's README and across the docs and comments.
tests/test_folders.py fails when a folder in apps/ has no app.json, or a folder in programs/ has no README with a Runs on line. I planted each fault once and each test failed.
I ran Ostinato's own tests (7 ok), tests/test_vamp.py with the link contract (10 ok, none skipped), the relative-import test, Vamp on bin/micropython for 5 seconds (bank opened, 4 tracks, pump rendering, no underruns), and Ostinato's browser page from its new folder under Playwright's Chromium (the UI loads, no page errors). I did not run Ostinato's Windows desktop window.