Repository navigation
DEPENDENCIES.lock: the CircuitPython oracle pin joins the one pin file - #402
Merged
Merged
Conversation
The oracle commit moves from CIRCUITPYTHON_ORACLE to a circuitpython line, unchanged. fetch_deps.sh skips that line and setup.py picks the mp3 line by name, so builds fetch what they did before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you build or contribute, the CircuitPython oracle commit is now the
circuitpythonline ofDEPENDENCIES.lock, with its history comment, and theCIRCUITPYTHON_ORACLEfile is gone. The commit is the same 40 characters.scripts/fetch_deps.shskips that line (the oracle is tested against, not fetched into.deps/), andsetup.pynow picks themp3line by name instead of taking the first one. The docs that named the old file point at the new place, and the roadmap keeps only the folder rename under Housekeeping, plus a bullet for__revision__onaudiocore,audiomp3,audiopumpandsynthio.The repository layout asks for one pin file, and two files meant two places to move a pin and two to read.
I compared the parsed pin before and after (mp3 and circuitpython commits identical), ran
fetch_deps.sh --checkwith the oracle line altered to show it ignores that line, and ran thetest_ci_scopeunit test. Nothing in the repo read the old file, so nothing reads the new line either. I did not run the parity gates or the full suite, and nothing verifies an oracle checkout against the pin; the clean-build job exercises the mp3 pin throughfetch_deps.sh.