Repository navigation
ci: a stub or the stub test runs the interpreter build - #408
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A change to a
.pyistub, or totests/test_stubs_match_modules.py, now also runs the clean-build job. That job is the only one with MicroPython built from the pull request, and the stub test's exact comparison with the MicroPython module only runs there; before this, a stub-only pull request skipped it and could pass CI with a stub that names something its module doesn't have.Every other scope rule is unchanged. The stub rule gains
build, and the stub test gets its own rule ahead of the generaltests/test_*.pyone, withlint,unitandbuild.I ran
tests/test_ci_scope.py(13 tests, passing). The updated stub case fails against the old rule, which I checked by restoring it. I haven't seen the new rule decide a real pull request; the first stub-only one will show it.