Repository navigation
AirSpace and ShimmerHall import on MicroPython - #14
Merged
Merged
Conversation
Both took the Reverb module with `from . import reverb`, which MicroPython sends through the package's lazy `__getattr__`. That only knows class names, so it raised `AttributeError: reverb` and neither effect could be imported. They now import `audioeffects.reverb` by its full name. On the unix MicroPython build, `import audioeffects.airspace` and `import audioeffects.shimmerhall` fail on main and import with this change. Fixes #13.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13. Both effects took the Reverb module with
from . import reverb. MicroPython sends that through the package's lazy__getattr__, which only knows class names, so it raisedAttributeError: reverband neither effect could be imported. They now importaudioeffects.reverbby its full name. No other module in the package imports a sibling that way.On the unix MicroPython build, both imports fail on main and succeed with this change. CPython's tests run in CI.