Repository navigation
Remove the audioeffects.rebuilt import path - #5
Merged
Merged
Conversation
The delay, reverb, pitch and rack classes moved to their own modules under audioeffects in 0.5.0, and audioeffects.rebuilt.<module> was kept as a thin alias. That alias is gone. Import a class from audioeffects (from audioeffects import Reverb) or from its module (audioeffects.reverb). The classes and what they render are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The delay, reverb, pitch and rack classes moved to their own modules under
audioeffectsin 0.5.0, andaudioeffects.rebuilt.<module>stayed as a thin alias so old imports kept working. This removes the alias and theaudioeffects.rebuiltsubpackage.If your code imports from
audioeffects.rebuilt, import the class fromaudioeffectsinstead (from audioeffects import Reverb) or from its module (audioeffects.reverb). The classes and what they render are unchanged;audioeffects.create(...)is unaffected.The wheel build lists one package fewer, the wheel gate now checks that the old path stays gone, and the changelog has a Removed entry.