Repository navigation
CI: a change to build_mp.py builds the GIGA firmware - #382
Merged
Merged
Conversation
build_mp.py checks the GIGA image's layout (the M4 pad), but a pull request that changed only build_mp.py built no stm32 image: the btclassic, h264enc and circuitpython workflows build esp32, rp2 and CircuitPython boards through it, and only the firmware workflow builds the GIGA. That workflow now runs on a build_mp.py change and builds just the mp-giga-shield cell. tests/test_ci_scope.py: a new test fails with the rule taken out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build_mp.py checks the GIGA image's layout, its M4 pad, but a pull request that changed only build_mp.py never built an stm32 image. The btclassic, h264enc and circuitpython workflows build esp32, rp2 and CircuitPython boards through build_mp.py when it changes. Only the firmware workflow builds the GIGA, and it didn't watch build_mp.py. #379 was such a change: its fix was proven only because it was also pushed onto #375, which moved a pin.
The firmware workflow now runs when build_mp.py changes, and
ci_scope.pybuilds just the mp-giga-shield cell for it rather than the whole set. A change to build_mp.py together with a cell row builds both.The scope tests pass, and the new one fails with the rule taken out. This PR changes build_mp.py's trigger, not build_mp.py itself, so its own run builds the whole set (the workflow file changed).