Repository navigation
Firmware modules: sayso leaves the build, the Spotify client ships with the apps - #397
Merged
Merged
Conversation
…th the apps sayso is the Spotify Web API client the apps use and needs a Spotify account and developer app, so it isn't a firmware building block. It stays available through the apps' libraries (omnipython-applibs, or mip install of applibs). The module, its docs rows and the wasm import check go.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sayso is the Spotify Web API client the apps use. It needs a Spotify account and a developer app, so it ships with the apps (omnipython-applibs, or the applibs mip package) and not with the firmware. This removes its firmware module, its row in the module docs and the web runtime's import check.
allglobs nothing named sayso, so no build list changes. No firmware was built; CI runs the web runtime build.