Repository navigation
audioif, cameraif, usbhost: type stubs and simpletests; btclassic, picotts: __revision__ - #399
Merged
Merged
Conversation
… picotts: __revision__ audioif, cameraif and usbhost ship .pyi stubs, checked name for name against each module's C tables (audioif's are audiobusio, audioio, audioi2sin, analogbufio and _audioif; usbhost's is _usbhost, the C half the usb packages use). cameraif and usbhost get a simpletest, the shortest program that proves the module works. btclassic and picotts report which source a firmware was built from in __revision__, set from git describe at build time like the other modules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last C modules on the docs template.
audioif, cameraif and usbhost get
.pyistubs, so an editor completes their API and the Stubs check reads them. Each name in the stubs matches the module's C tables (audioif's stubs areaudiobusio,audioio,audioi2sin,analogbufioand_audioif; usbhost's is_usbhost, the C half the usb packages sit on, since there is no importableusbhost). A script compared every module's global table and theCameraclass's members with the stubs: no name is missing or extra. Each stub passes mypy.btclassic.__revision__andpicotts.__revision__come from git describe at build time, the way cameraif's does, through the Make and CMake glue (btclassic on esp32, rp2 and unix; picotts via_picotts, which picotts.py passes on). I haven't built them locally; CI's firmware builds are the proof.cameraif_simpletest.pyran on an ESP32-P4X-EYE with an OV2710 and printed the sensor, the 1920x1080 frame size and a 4,147,200-byte frame.usbhost_simpletest.pyran on a P4 WIFI6 DEV-KIT with nothing plugged into the host port: the host started, printed0 USB device(s) foundand stopped cleanly. It hasn't listed a real device yet.