Repository navigation
firmware modules: list modules pinned in DEPENDENCIES.lock - #223
Merged
Merged
Conversation
micropython-pydevices is moving its pins into one DEPENDENCIES.lock, read through build_mp.py's lock(). The module listing takes the not yet fetched modules from there when build_mp.py has it, and from modules.lock otherwise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mpftp firmware moduleslists the modules a micropython-pydevices checkout pins but hasn't fetched yet, marked "fetched on first build". It found them by callingbuild_mp.py'sread_lock("modules.lock"). micropython-pydevices is moving its pins into oneDEPENDENCIES.lock, read through a newlock()inbuild_mp.py, so the listing now useslock()and its module lines when the checkout'sbuild_mp.pyhas it, andread_lock("modules.lock")when it doesn't. Without this the listing wouldn't fail on the new checkout (the call was already in atry), it would just stop showing the unfetched modules.The build-firmware guide's sentence about those modules no longer names the old file.
cli/tests/test_firmware_build.pypasses, with a new case where the fakebuild_mp.pyhaslock()in place ofread_lock(). Run against a checkout of micropython-pydevices' branch with the new file, withmodules/ulabmoved away, the listing shows audiodsp and pygraphics as present and ulab as not fetched yet, and no toolchain or MicroPython line as a module.