Repository navigation
File transfer: show the bytes moved inside one large file - #226
Merged
Merged
Conversation
A single big file used to show only elapsed time. The status line now says how far into the file the transfer is, for example 315.5 KB of 512.0 KB, 61%, from the byte counts the sidecar already sends. The browser panel and the VS Code extension both show it. Checked with a 512 KB put to a board over USB serial: the line stepped from 0% to 96% as the file moved, where before it only counted seconds. The new tests fail without the change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A single big file used to show only elapsed time. The status line now says how far into the file the transfer is, for example 315.5 KB of 512.0 KB, 61%, from the byte counts the sidecar already sends. The browser panel and the VS Code extension both show it.
Checked with a 512 KB put to a board over USB serial: the line stepped from 0% to 96% as the file moved, where before it only counted seconds. The new tests fail without the change.