Repository navigation
Guides name the module lvgl; the MicroPython port builds on Windows again - #1
Merged
Merged
Conversation
micropython-pydevices' build_mp.py builds LVGL as --modules lvgl for either interpreter, fetched at its modules.lock pin or from a checkout beside it. The firmware guides and Show JPEG images use that name, and say how to build another checkout by its port's path.
The per-object flag rules named each LVGL source three ways. The
second spelling kept a source's absolute path when its pattern didn't
match, and on Windows that path holds a drive colon, which make reads
as a static pattern rule ("target pattern contains no '%'"). Every
spelling with a colon is now dropped.
bdbarnett
changed the title
…a drive The previous fix dropped every spelling with a colon, and on Windows the build directory is absolute (D:/...), so no flag rule was left and LVGL failed -Werror=double-promotion. Only the part under the build directory is checked now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
micropython-pydevices' build_mp.py builds LVGL as --modules lvgl for
either interpreter, fetched at its modules.lock pin or from a checkout
beside it. The firmware guides and Show JPEG images use that name, and
say how to build another checkout by its port's path.