Repository navigation
MicroPython: the assert handler links on stm32 - #14
Merged
Merged
Conversation
lv_micropython_assert_failed used strrchr to trim the file name, and the stm32 port's C library has none, so the Arduino GIGA build failed to link. A loop does the same job.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The assert handler from #13 trimmed the file name with
strrchr, which the stm32 port's C library doesn't provide, so the Arduino GIGA build stopped linking (undefined reference to strrchr). A short loop keeps the same behaviour: it takes what follows the last/or\\, or the whole name when there is neither. Checked the loop alone on gcc with a Unix path, a Windows path and a bare name; the GIGA build itself is checked when the firmware repository moves its pin to this commit.