Repository navigation
lv_conf.h: a build can leave out a built-in Montserrat size - #7
Merged
Merged
Conversation
Every LV_FONT_MONTSERRAT_<n> in lv_conf.h is now an #ifndef default, and the generator wraps each Montserrat font's wrapper and module entry in #if on that switch, in the MicroPython, CircuitPython and CPython bindings. A firmware short of flash passes -DLV_FONT_MONTSERRAT_40=0 and the 40 px font drops out without lv_conf.h being edited or the binding regenerated. Ran ./regenerate_all.sh, then scripts/verify_bindings.sh (passes) and the generator, MicroPython-port and CircuitPython-port tests (128 passed).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A firmware short of flash can now drop one of the compiled-in Montserrat sizes with a define, such as
-DLV_FONT_MONTSERRAT_40=0, without editinglv_conf.hor regenerating the binding. EveryLV_FONT_MONTSERRAT_<n>inlv_conf.his an#ifndefdefault now, and the generator wraps each Montserrat font's wrapper struct and module entry in#ifon that switch, in the MicroPython, CircuitPython and CPython bindings. The fonts reference page says how, and that the font can still be loaded at run time fromfonts/.The Arduino GIGA R1 needs this: with displayif, LVGL's 40 px font is what doesn't fit in its 1280 KB firmware slot.
I ran
./regenerate_all.sh(only the guards changed ingenerated/;api.jsonandlvgl.pyiare unchanged),scripts/verify_bindings.sh, which passes, and the generator, MicroPython-port and CircuitPython-port tests (128 passed, three of them new). A GIGA R1 firmware built from this branch with-DLV_FONT_MONTSERRAT_40=0links and runs LVGL:lvgl.font_montserrat_40is absent andfont_montserrat_32is present. I didn't build a CircuitPython or CPython target with a size turned off.