Repository navigation
midiports: pip install pydevices-desktop brings midiports and adafruit_midi - #453
Merged
Merged
Conversation
…t_midi On CPython the only way to get midiports was mip or a hand-copied folder, and adafruit_midi came from Adafruit's own package, which pulls in Blinka. midiports is marked pypi-desktop in mip-split.toml, so the release builds pydevices-desktop with the files packages/midiports/package.json lists: midiports, and adafruit_midi at the same pinned tag mip uses. Needs the release tooling that reads the key (PyDevices/.github#106). Ran: tests/test_mip_split.py, test_libbuild.py, libbuild check; installed the wheel built from this tree in a clean venv and imported midiports and adafruit_midi.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #445.
pip install pydevices-desktopwill includemidiportsandadafruit_midi, so MIDI code runs on a desktop or a Raspberry Pi withoutmipor a copied folder. I picked the desktop package over thepydeviceswheel becausemidiportsis only useful with a host's own ports there, and I bundledadafruit_midiat the tag mip already pins (1.6.0, fetched when the wheel is built) instead of depending onadafruit-circuitpython-midi, which pulls in Blinka that a desktop doesn't need.mip-split.tomlmarks the packagepypi-desktop = true; the package README says the pip route.Don't merge before PyDevices/.github#106 is tagged and the workflows here point at that tag: the current release tooling rejects the new key.
What I ran:
test_mip_split.pyandtest_libbuild.pypass,libbuild checkis clean. With the tooling change from #106 I built both wheels from this tree and installedpydevices-desktopin a clean Python 3.14 venv:import midiports,from midiports import linuxandadafruit_midi.note_on.NoteOn(60, 100)work, and no Blinka was installed. On 0.8.0.dev3 from TestPyPIimport midiportsfails, as reported. I did not run it against a USB MIDI device on a Pi.