Repository navigation
Raise the build stack to the shared baseline and drop --upgrade from install lines - #872
Conversation
…install lines environment.yml and the Colab workflow take quantecon-book-theme 0.22.2, sphinx-exercise 1.2.2 and sphinx-proof 0.4.1 (and sphinxcontrib-youtube 1.5.0 in the Colab workflow), the newest releases, which the QuantEcon lecture monorepo's one environment pins (QuantEcon/lectures#70). Five install lines drop --upgrade: in a build every lecture shares one environment, so an --upgrade line replaces the pinned version for every lecture executed after it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WT8bMacV9Lmy1VLUc6XJoL
✅ Deploy Preview for taupe-gaufre-c4e660 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
🔵 Needs a closer look
The change alters Colab runtime dependency behavior by removing --upgrade from pip install yfinance/wbgapi, which could leave users on preinstalled package versions that may break data fetching, so it requires a human sanity-check in the target environment before approval.
No open issues 🎉
What changed in this PR
Raises the build stack to the shared QuantEcon baseline and removes pip install --upgrade from select notebooks to prevent environment drift during builds.
Changes:
- Update
environment.ymldoc-build dependency pins (e.g.,quantecon-book-theme,sphinx-exercise,sphinx-proof) to baseline versions. - Align the Colab CI workflow’s pinned build stack (including
sphinxcontrib-youtube==1.5.0) with the baseline. - Drop
--upgradefrom!pip installcells in five lectures so later executed notebooks don’t override pinned dependencies.
| File | Description |
|---|---|
| lectures/observed_distributions.md | Removes --upgrade from the yfinance install cell to avoid mutating the shared build environment. |
| lectures/mle_intro.md | Removes --upgrade from the yfinance install cell to prevent cross-lecture dependency drift during builds. |
| lectures/heavy_tails.md | Removes --upgrade from the yfinance wbgapi install cell to keep the environment consistent across executed lectures. |
| lectures/fitting_distributions.md | Removes --upgrade from the yfinance install cell to avoid overriding pinned versions in the build environment. |
| lectures/bivariate_dist.md | Removes --upgrade from the yfinance install cell (in the exercise solution) to prevent environment-wide upgrades during builds. |
| environment.yml | Bumps pinned documentation build dependencies to the shared baseline versions. |
| .github/workflows/collab.yml | Updates the Colab CI workflow to install a baseline-aligned, pinned doc-build stack (including sphinxcontrib-youtube==1.5.0). |
Review effort: Balanced
Copilot was unable to complete this review at the selected tier due to model policy or plan restrictions.
|
Full site validation: no new warning, no regression.
|
What
The first of six pull requests, one per series, that bring the lecture series to one up-to-date baseline: the environment the QuantEcon lecture monorepo's sites are to build in, pinned in QuantEcon/lectures#70 (
_base/environment-update.yml). Intro goes first as the pilot.environment.yml.github/workflows/collab.ymlbivariate_dist,fitting_distributions,heavy_tails,mle_intro,observed_distributions!pip install --upgrade yfinance(withwbgapiinheavy_tails) becomes!pip install yfinanceWhy the install lines change
In a build every lecture runs in one environment, so an
--upgradeline replaces the version the environment pins for every lecture executed after it, and the build no longer runs on the versions it was set up with. Without--upgradethe line installs the package where it is missing and leaves it alone where it is there. The lecture monorepo pins yfinance and wbgapi exactly; this series' own build installs the newest when the line runs, as before.For the reviewer: Colab ships its own yfinance, so a reader running one of these notebooks there now gets Colab's version instead of the newest. yfinance follows changes on Yahoo's side, so an older one can stop fetching; whether that matters for these five lectures is a judgement for the review.
Checks
This changes lecture content (five install lines) and the software the series builds with, so it needs a person's review; the preview build is the check that the five lectures and the theme render as before.
🤖 Generated with Claude Code
https://claude.ai/code/session_01WT8bMacV9Lmy1VLUc6XJoL