Skip to content

bibliography: set the 23 ruled entries to the lecture monorepo's - #1140

Open
mmcky wants to merge 1 commit into
mainfrom
bibliography-pool-rulings
Open

mmcky wants to merge 1 commit into
mainfrom
bibliography-pool-rulings

Conversation

@mmcky

@mmcky mmcky commented Nov 22, 2026 •

Copy link
Copy Markdown
Contributor

What

This file holds 58 entries that a ruling covers; this sets the 23 of them that differ to the lecture monorepo's merged bibliography (QuantEcon/lectures, lectures/_static/quant-econ.bib). Each of those keys is settled there by a ruling in sync/bib.yml: the owner's rulings of 2026-11-02 (QuantEcon/project-monorepo#10), the four rules accepted on 2026-10-12, or a style fix of decision D3. On 2026-11-22 the owner asked for lecture fixes to be reported upstream to their source of truth, and chose to set every ruled entry a series holds to the pool's, cited or not ("All ruled entries (Recommended)").

It is mechanical. Each changed entry equals the pool's once both are normalised as tools/bib-merge reads them, and every other entry is untouched; a script checked both. Fields the house style leaves out (month, abstract, keywords, file, date-added, date-modified, issn) are kept as this file had them; an empty field, such as doi = {}, is dropped, as the pool's normaliser drops it. The changed entries are written in the pool's layout, one field per line.

Intermediate's lectures cite 13 of the 23: the 5 corrections below and 8 of the rest.

Corrections to entries this series cites (5)

Key Why What changes (this file → the pool's)
Hansen_Jagannathan_1991 the owner's ruling doi: 10.1086/261750 → 10.1086/261749; title: Implications of Security Market Data for Models of Dynamic Economies → {Implications of Security Market Data for Models of Dynamic Economies}
HansenRichard1987 a broken copy title: … Deducing Testable Restrictions Implied by Dynamc Asset Pricing Models → …Deducing Testable Restrictions Implied by Dynamic Asset Pricing Models
KydlandPrescott1977 the owner's ruling pages: 473--492 → 473--491
MarcetMarshall1992 a style fix entry type: incollection → techreport; booktitle: Universitat Pompeu Fabra Economics Working Paper → (none); institution: (none) → Universitat Pompeu Fabra; type: (none) → Economics Working Paper
ModiglianiBrumberg1954 a style fix publisher: (none) → Rutgers University Press

The rest (18)

  • 5 not cited, the owner's ruling
  • 4 cited, the rule: one copy has more fields
  • 4 cited, the rule: the same fact written two ways
  • 4 not cited, the rule: one copy has more fields
  • 1 not cited, a broken copy

"The owner's ruling" and "a broken copy" correct the data: the wrong paper, author, year, pages or journal, or a malformed entry. "More fields" adds what another series' copy has, such as a DOI. "The same fact written two ways" and "cosmetic differences" settle on one spelling of the same data.

Validation

Done on 2026-11-22, a full validation: fresh builds with no cache of this pull request and of main, every notebook executed, both green. The evidence is in the comment below.

This changes content, so it needs a person's review.

🤖 Generated with Claude Code

https://claude.ai/code/session_01WT8bMacV9Lmy1VLUc6XJoL

Each of these keys is settled in the lecture monorepo's merged bibliography
(QuantEcon/lectures, sync/bib.yml) by the owner's rulings of 2026-11-02,
the rules accepted on 2026-10-12 or a style fix of decision D3. On
2026-11-22 the owner asked for every ruled entry a series holds to be set
to the pool's. Each changed entry equals the pool's once both are
normalised; every other entry is untouched, and the fields the house style
leaves out (month, abstract, keywords and others) are kept as they were.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WT8bMacV9Lmy1VLUc6XJoL
@github-actions

Copy link
Copy Markdown

📖 Netlify Preview Ready!

Preview URL: https://pr-1140--sunny-cactus-210e3e.netlify.app

Commit: 148a901


Build Info

@mmcky

mmcky commented Nov 22, 2026

Copy link
Copy Markdown
Contributor Author

Validation: a full validation

Two fresh builds with no cache, each executing all 159 notebooks on the series' GPU machine (cache.yml), both green:

Build Run
main at 220fb97, this branch's base, 2026-11-22 45012272650
this pull request at 148a901, 2026-11-22 45012277463

What a reader sees change. Only the references page: no in-text citation changes on any lecture page.

  • Hansen and Jagannathan (1991): the DOI is now 10.1086/261749, the article itself; the old one, 10.1086/261750, is the next article in the issue. Its title is now set in title case.
  • Hansen and Richard (1987): "dynamc" corrected to "dynamic".
  • Kydland and Prescott (1977): pages 473–491, where it said 473–492.
  • Marcet and Marshall (1992): now a working paper of Universitat Pompeu Fabra, number 13, where it was set as a chapter in a book named after the series.
  • Modigliani and Brumberg (1954): its publisher, Rutgers University Press.
  • Smaller changes:
    • "Econometrica, Journal of the Econometric Society" becomes "Econometrica";
    • Hansen and Singleton's journal is capitalised, Journal of Political Economy;
    • Ljungqvist and Sargent gain their full names and the ISBN;
    • Lubik and Schorfheide (2004), Sargent and Stachurski (2025) and Sims (1982) gain their DOIs;
    • Piazzesi, Salomao and Schneider (2015) gains its month. Its note and year now read "March 2015, 2015", which is redundant; that is for the merged bibliography to tidy.

Cell outputs. No code changed, so nothing executes differently. The output lines that differ, on 23 pages, are the same as between any two builds: unseeded draws, timings and solver printouts. The warnings in the cell outputs are the same on both sides, page by page.

Build logs. The same warning lines on both sides, and no Sphinx warning on either.

25 of 176 pages differ in all: the references page, the 23 of output noise, and the status page (build times).

@mmcky
mmcky marked this pull request as ready for review November 22, 2026 12:48
Copilot AI adaptive review requested due to automatic review settings November 22, 2026 12:49

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Because the change updates 23 authoritative bibliographic records from external rulings and source-of-truth data, automated consistency checks cannot replace human verification of citation accuracy and ruling provenance.

No open issues 🎉

What changed in this PR

Synchronizes 23 ruled bibliography entries in the lecture monorepo with QuantEcon’s merged bibliography, correcting metadata while preserving required local fields.

Changes:

  • Corrects DOI values, page ranges, titles, author names, publishers, and other bibliographic facts.
  • Converts MarcetMarshall1992 to the appropriate technical-report format.
  • Normalizes BibTeX formatting and adds missing metadata across the affected entries.
File Description
lectures/​_static/​quant-econ.bib Synchronizes 23 ruled bibliography entries with the merged QuantEcon bibliography and normalizes their metadata and formatting.

Review effort: Lite (adaptive)

@mmcky

mmcky commented Nov 22, 2026

Copy link
Copy Markdown
Contributor Author

A correction to the validation comment above: its Build logs line says the two builds logged the same warning lines. They differ by one. While this pull request's build installed its packages, pip logged one retry after a dropped connection (WARNING: Retrying … ConnectionResetError(104, 'Connection reset by peer'), downloading the CUDA wheels), and the download then succeeded. Both builds installed the same 61 pip packages, at the same versions. There is no Sphinx warning on either side, so the rest of the comment stands. My comparison script had missed the line; it has been fixed, and the other comparisons made today were checked again with it and are unaffected.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants