Repository navigation
site-build: advanced joins the base environment - #86
Conversation
Step 2 of bringing the sites into one environment for every site (QuantEcon/project-monorepo#77), by the owner's order of 2026-11-22: intro, then advanced, then the GPU sites. sites/advanced/site.yml sets environment: base, and SITES is dp intro advanced; the comments and both READMEs name it. advanced builds HTML alone for now, as intro and dp do. Its three Kaleido lectures (BCG_complete_mkts, BCG_incomplete_mkts and knowing_forecasts_of_others) export images with kaleido 1.5.2, which needs a Chrome: the full image carries Chrome for Testing at /opt/chrome with BROWSER_PATH set since QuantEcon/actions#346. The environment scan of 2026-11-19 built advanced in this environment before that Chrome arrived, and those three were its only failures. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WT8bMacV9Lmy1VLUc6XJoL
Validation: advanced built from the pool against advanced's own buildsBuilds compared, all of advanced's
Noise baseline. advanced's two own builds differ on 27 of 85 pages: image file names, unseeded random outputs, timings, memory addresses and solver iteration printouts. This pull request's build differs from the first on 78 pages. Every difference beyond the noise is one of these:
Warnings. The build log has no Sphinx warning; its only warning lines are Node.js deprecation notices from GitHub's own actions and conda's update notice. The cell outputs carry the same warnings as advanced's own build, page by page:
Environment. All 39 pins in (Corrected 2026-11-22: two counts, found in review; the conclusions are unchanged.) |
There was a problem hiding this comment.
🟢 Approval recommended
The review reports no active issues with moving advanced to the shared base environment and adding it to site-build CI.
No open issues 🎉
What changed in this PR
This PR moves advanced into the shared base environment after intro and adds it to the site-build workflow, continuing the staged migration toward one environment for all sites.
Changes:
- Sets advanced to use the base environment, documenting Chrome support for its Kaleido image exports.
- Adds advanced to CI alongside dp and intro.
- Updates documentation and workflow comments without changing the cache-key-sensitive environment package list.
| File | Description |
|---|---|
sites/README.md |
Documents advanced’s base environment and inclusion in CI. |
sites/advanced/site.yml |
Selects the base environment and explains its Chrome dependency. |
.github/workflows/site-build.yml |
Adds advanced to SITES and updates explanatory comments. |
_base/README.md |
Lists intro and advanced as current base-environment users. |
Review effort: Balanced (adaptive)
What
Step 2 of bringing the sites into one environment for every site (QuantEcon/project-monorepo#77), in the owner's order of 2026-11-22 (intro, then advanced, then the GPU sites; QuantEcon/project-monorepo#77, comment of 2026-11-22). Intro moved in #84.
sites/advanced/site.ymlenvironment: base, with a comment saying why.github/workflows/site-build.ymlSITES: dp intro advanced; the comments name advanced; "Only an ubuntu-latest series site has a leg" now reads "Only the ubuntu-latest runner class has a leg so far, in either environment"; two comment blocks re-flowed and theSITEScomment re-wrapped (the review of #85)sites/README.md,_base/README.md_base/environment-update.ymlis not touched. Its whole text is hashed into the base environment's cache key, so even a comment edit would make intro build cold again. Its stale comment lines wait for the pull request that removesplotly-orca, which edits it anyway.advanced's three Kaleido lectures (BCG_complete_mkts, BCG_incomplete_mkts, knowing_forecasts_of_others) export images with kaleido 1.5.2, which needs a Chrome. The full image has carried Chrome for Testing at
/opt/chrome, withBROWSER_PATHset, since QuantEcon/actions#346. The environment scan of 2026-11-19 built advanced in this environment before that Chrome arrived, and those three pages were its only failures. This build is their first in the image with Chrome.The job limit is 240 minutes (
cell_timeout7200 s plus 120). advanced builds HTML alone for now, as intro and dp do.Validation
Done on 2026-11-22; the evidence is in the comment below. The advanced leg builds green and strict (
-n -W) from the pool in the full image with the list, all 80 notebook pages executed, the three Kaleido lectures included. Against two fresh builds of advanced's own at the same commit, every difference beyond their noise is one of these: the full image's install output; citation anchors; the merged bibliography's corrections of four of advanced's entries; cvxopt's GLPK being found bypolytope; platform round-off; or plotly's text drawn in a different font by the image's Chrome. The last is cosmetic, and visible. The cell-output warnings are the same, and all 39 pins are installed.🤖 Generated with Claude Code
https://claude.ai/code/session_01WT8bMacV9Lmy1VLUc6XJoL