Skip to content

R-only QR and LQ decomposition - #606

Merged
lkdvos merged 6 commits into
mainfrom
r-only-qr
Nov 2, 2026
Merged

lkdvos merged 6 commits into
mainfrom
r-only-qr

Conversation

@Yue-Zhengyuan

Copy link
Copy Markdown
Member

@codecov

codecov Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread test/factorizations/ortho.jl Outdated
Comment on lines +62 to +63
@test Q2 === Q0
@test R2 === R0

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think in general we don't really add these tests, mostly because we aren't necessarily guaranteeing this (see docstrings of the relevant functions that explicitly state that we may or may not have in-place operations depending on the backend).

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed just now.

Comment thread test/factorizations/ortho.jl Resolved
@Yue-Zhengyuan

Copy link
Copy Markdown
Member Author

@kshyatt Is enzyme test timeout expected?

@lkdvos
lkdvos merged commit 9056e3b into main Nov 2, 2026
42 of 45 checks passed
@lkdvos
lkdvos deleted the r-only-qr branch November 2, 2026 12:58
@lkdvos

lkdvos commented Nov 2, 2026

Copy link
Copy Markdown
Member

Should be unrelated in any case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants