Closed
Labels
P3Low priority / Polish & EnhancementsLow priority / Polish & EnhancementsenhancementNew feature or requestNew feature or requesterror-handlingTheme parser epic label: error-handlingTheme parser epic label: error-handlingtestsTheme parser epicTheme parser epic
Description
Problem
Nothing stops a new `catch (_) {}` in the UI layer, so the silent failures audited in the sibling issue come back. The repo already has guard tests (for example the shadcn imports ratchet).
Proposal
A guard test (or analyzer rule) over `lib/features` and `lib/shared`: a `catch` block must not be empty; it must call `logIgnored`, the reporting helper, rethrow or handle the error. Start as a ratchet with the current count so existing sites do not block merges, and lower it as the audit proceeds.
Also worth a look in the same pass: the 301 `unawaited(...)` calls; an exception there reaches only `runZonedGuarded` and `debugPrint`.
Part of the error-handling epic.
Metadata
Metadata
Assignees
Labels
P3Low priority / Polish & EnhancementsLow priority / Polish & EnhancementsenhancementNew feature or requestNew feature or requesterror-handlingTheme parser epic label: error-handlingTheme parser epic label: error-handlingtestsTheme parser epicTheme parser epic
Activity
Merge pull request #1801 from QueryaHub/test/no-silent-catch-guard
ZhuchkaTriplesix commentedon Oct 25, 2026
Fixed on dev in #1801 (merged). Closing by hand: the PRs target dev, so GitHub would only close this when dev is merged into main.