Repository navigation
fix(hy-memory): cap the prefill chunk at 1024 on HRX - #982
Merged
Merged
Conversation
…ts / hang above ~2k tokens) On HRX a prefill chunk of ~2k rows or more makes an NPU dispatch time out (amdxdna ert state 8, DEADLINE_EXCEEDED) and the request hangs or returns garbage. XRT is not affected, so only FLM_USE_HRX builds are capped. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hy-memory on HRX: cap the prefill chunk at 1024
Problem. With the HRX runtime, a Hy-Memory prompt of about 2k tokens or more hangs. The engine's prefill overlay dispatches time out (
amdxdna dispatch timed out: ert state 8,DEADLINE_EXCEEDED), the engine carries on with the failed result, and the request either never returns or returns garbage. Found while updating the IRON baseline: the HRX GSM8K bench stalled once (3 timeouts in a row), and the HRX perf bench recorded a nonsense decode speed (1100+ tok/s, TTFT 20 s at 1k) because the dispatches failed instantly.Measured (HRX portable build
b908208a, Strix Halo, local weights):HY_MEM_MM_HOST=1 HY_MEM_ATTN_HOST=1)--prefill-chunk-len 1024flm bench hy-memory:30b-a3b -c 4096Fix. In
HyMemory::insert, onFLM_USE_HRXbuilds only, clampmeta_info.max_prefill_lento 1024 (the value tested above). XRT keeps the catalog's 16384 (the engine splits at 4096): it is unaffected by this problem and is faster with big chunks (the MoE expert matmuls pad each expert to 256 rows). Verified on the XRT build: smoke and determinism pass, prefill 180 / 242 tok/s at 1k / 2k tokens, unchanged.Not done / follow-up. The underlying cause is in the engine or the HRX runtime (a long-chunk dispatch of the prefill overlay). This only avoids it. The HRX baseline for hy-memory should be (re)generated after this lands; the XRT baseline is already merged (IRON#171).
🤖 Generated with Claude Code