Skip to content

[BSP][NXP] Add new features of I2C DMA, CAN, SPI, DWT and SDIO for RT1180 - #11715

Open
nxp-ran wants to merge 52 commits into
RT-Thread:masterfrom
nxp-ran:feature/imxrt1180-industrial-control
Open

[BSP][NXP] Add new features of I2C DMA, CAN, SPI, DWT and SDIO for RT1180#11715
nxp-ran wants to merge 52 commits into
RT-Thread:masterfrom
nxp-ran:feature/imxrt1180-industrial-control

Conversation

@nxp-ran

@nxp-ran nxp-ran commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

Add new features of I2C DMA, CAN, SPI, DWT and SDIO for RT1180, and fix some bugs in uart driver.

请提供验证的bsp和config (provide the config and bsp)

  • BSP: bsp/nxp/imx/imxrt/imxrt1180-nxp-evk
  • .config:
    I2C DMA:
    BSP_USING_I2C
    BSP_USING_I2C2
    BSP_I2C2_USING_DMA
    BSP_USING_I2C3
    BSP_I2C3_USING_DMA

CAN:
BSP_USING_CAN
BSP_USING_CAN3

SPI:
BSP_USING_SPI
BSP_USING_SPI3
BSP_SPI3_USING_DMA

DWT:
BSP_USING_DWT

SDIO:
BSP_USING_FS
BSP_USING_SDCARD_FATFS
BSP_USING_SDIO

  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用clang-format 源码格式化工具确保格式符合RT-Thread代码规范 This PR has been formatted with clang-format and complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

nxp-ran added 30 commits July 31, 2026 17:13
…erram, multicore kickoff, rpmsg-lite, netc, cherryusb and ethercat.
…ticore kick-off and different loading methods
…rt hypperram, multicore kickoff, rpmsg-lite, netc, cherryusb and ethercat.
… supporting multicore kick-off and different loading methods.
….mac files of CM7 to support deugging in iar.
…ation to place all flash operation code in RAM.
… but still cannot work in CM7. Will continue to update in next version.
…ot been uploaded. And added CONFIG_BSP_USING_GPIO=y for Peripheral.netc.:
nxp-ran added 13 commits August 17, 2026 14:07
…-industrial-control

# Conflicts:
#	bsp/nxp/imx/imxrt/imxrt1180-nxp-evk/README.md
#	bsp/nxp/imx/imxrt/imxrt1180-nxp-evk/README_zh.md
#	bsp/nxp/imx/imxrt/imxrt1180-nxp-evk/cm33/.ci/attachconfig/ci.attachconfig.yml
#	bsp/nxp/imx/imxrt/imxrt1180-nxp-evk/cm33/.config
#	bsp/nxp/imx/imxrt/imxrt1180-nxp-evk/cm33/board/Kconfig
#	bsp/nxp/imx/imxrt/imxrt1180-nxp-evk/cm33/board/MCUX_Config/pin_mux.c
#	bsp/nxp/imx/imxrt/imxrt1180-nxp-evk/cm33/board/board.c
#	bsp/nxp/imx/imxrt/imxrt1180-nxp-evk/cm7/.ci/attachconfig/ci.attachconfig.yml
#	bsp/nxp/imx/imxrt/imxrt1180-nxp-evk/cm7/.config
#	bsp/nxp/imx/imxrt/imxrt1180-nxp-evk/cm7/applications/mnt.c
#	bsp/nxp/imx/imxrt/imxrt1180-nxp-evk/cm7/board/Kconfig
#	bsp/nxp/imx/imxrt/imxrt1180-nxp-evk/cm7/board/MCUX_Config/pin_mux.c
#	bsp/nxp/imx/imxrt/imxrt1180-nxp-evk/cm7/board/SConscript
#	bsp/nxp/imx/imxrt/imxrt1180-nxp-evk/cm7/board/board.c
#	bsp/nxp/imx/imxrt/imxrt1180-nxp-evk/cm7/board/ports/flexspi_port.h
#	bsp/nxp/imx/imxrt/imxrt1180-nxp-evk/cm7/rtconfig.h
#	bsp/nxp/imx/imxrt/libraries/drivers/drv_uart.c
#	bsp/nxp/imx/imxrt/libraries/drivers/drv_uart_v2.c
@nxp-ran
nxp-ran requested a review from Rbb666 as a code owner August 17, 2026 08:22
@github-actions

Copy link
Copy Markdown

👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流(如果格式化CI运行失败)。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).


🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page
    点击进入工作流 → | Click to open workflow →

  2. 点击 Run workflow | Click Run workflow

  • Use workflow from 保持默认分支(通常为 master
    Keep the default branch (usually master) in Use workflow from
  • branch 输入框填写 PR 分支 feature/imxrt1180-industrial-control
    Enter PR branch feature/imxrt1180-industrial-control in the branch field
  • 设置需排除的文件/目录(目录请以"/"结尾)
    Set files/directories to exclude (directories should end with "/")
  1. 等待工作流完成 | Wait for the workflow to complete
    格式化后的代码将作为独立提交推送至你的分支。
    The formatting changes will be pushed to your branch as a separate commit.

完成后,提交将自动更新至 feature/imxrt1180-industrial-control 分支,关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the feature/imxrt1180-industrial-control branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们,再次感谢您的贡献!💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

@github-actions github-actions Bot added BSP: NXP Code related with NXP BSP labels Aug 17, 2026
@nxp-ran nxp-ran closed this Aug 17, 2026
@nxp-ran nxp-ran reopened this Aug 17, 2026
@nxp-ran nxp-ran closed this Aug 17, 2026
@nxp-ran nxp-ran reopened this Aug 17, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the NXP i.MXRT BSP (focused on RT1180 EVK) to add/enable RT1180-specific peripheral features (DMA routing, new RTC implementation, SDIO cache maintenance, etc.) and to align board configs/Kconfig/CI attach configs with the new capabilities.
本 PR 更新了 NXP i.MXRT BSP(主要面向 RT1180 EVK),新增/使能 RT1180 相关外设能力(DMA 路由、新 RTC 实现、SDIO Cache 维护等),并同步更新板级配置、Kconfig 与 CI 附加配置。

Changes / 变更:

  • Add RT1180-specific DMA request mux/base handling for LPUART and LPSPI; adjust SPI init/export stage.
    为 LPUART/LPSPI 增加 RT1180 专用 DMA request mux/base 处理;调整 SPI 初始化/导出阶段。
  • Add a new BBNSM-based RTC driver for RT1180 and a generic DWT cycle-counter utility driver.
    为 RT1180 新增基于 BBNSM 的 RTC 驱动,并新增通用 DWT 周期计数/延时工具驱动。
  • Update SDIO driver (RT1180 cache maintenance), board pinmux, Kconfig/.config, CI attachconfig, and BSP READMEs to reflect supported peripherals.
    更新 SDIO 驱动(RT1180 Cache 维护)、板级 pinmux、Kconfig/.config、CI attachconfig 与 BSP README 外设支持状态。

PR metadata checks / PR 元信息检查(需要作者处理)

  • Title: current prefix is uppercase ([BSP][NXP]). Repo convention expects lowercase prefix; consider something like:
    English: [nxp][imxrt] Add RT1180 I2C/SPI/CAN/SDIO/DWT + BBNSM RTC
    中文:当前标题前缀为大写([BSP][NXP]),建议按仓库惯例改为小写前缀,例如:[nxp][imxrt] ...
  • Description: still contains the template bracket wrapper and the “action” link is empty; please clean it up and add the CI/action link if required.
    中文:描述里仍保留了模板方括号包裹内容,且 action 链接为空;建议清理并补充验证/CI 链接。

Reviewed changes

Copilot reviewed 40 out of 46 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
bsp/nxp/imx/imxrt/libraries/drivers/SConscript Select RT1180 RTC driver; add DWT build hook
bsp/nxp/imx/imxrt/libraries/drivers/drv_uart.c RT1180 eDMA base/mux handling; DMA ISR tweaks
bsp/nxp/imx/imxrt/libraries/drivers/drv_uart_v2.c ISR overrun handling order; disable IRQ sources on close
bsp/nxp/imx/imxrt/libraries/drivers/drv_timer.c Style/formatting; RT1180/1170 clock timer guard cleanup
bsp/nxp/imx/imxrt/libraries/drivers/drv_spi.c RT1180 DMA routing + noncacheable DMA structs; init stage change
bsp/nxp/imx/imxrt/libraries/drivers/drv_sdio.c RT1180 GPIO/cache-maintenance adjustments; clock/div handling
bsp/nxp/imx/imxrt/libraries/drivers/drv_rtc_bbnsm.h New RT1180 BBNSM RTC header
bsp/nxp/imx/imxrt/libraries/drivers/drv_rtc_bbnsm.c New RT1180 BBNSM RTC implementation
bsp/nxp/imx/imxrt/libraries/drivers/drv_lpadc.c Minor formatting/cleanup in LPADC driver
bsp/nxp/imx/imxrt/libraries/drivers/drv_gpio.h Minor macro formatting
bsp/nxp/imx/imxrt/libraries/drivers/drv_gpio.c Large formatting + RT1180 pinmap content organization
bsp/nxp/imx/imxrt/libraries/drivers/drv_flexspi.h Minor formatting cleanup
bsp/nxp/imx/imxrt/libraries/drivers/drv_flexspi.c Minor formatting cleanup; RT1180 LUT formatting
bsp/nxp/imx/imxrt/libraries/drivers/drv_dwt.h New DWT utility header
bsp/nxp/imx/imxrt/libraries/drivers/drv_dwt.c New DWT utility implementation + finsh test cmd
bsp/nxp/imx/imxrt/libraries/drivers/drv_can.c Add RT1180 improved timing path; formatting cleanup
bsp/nxp/imx/imxrt/libraries/drivers/drv_adc.c Minor formatting cleanup
bsp/nxp/imx/imxrt/imxrt1180-nxp-evk/README.md Mark SPI/SDIO/RTC/CAN as supported
bsp/nxp/imx/imxrt/imxrt1180-nxp-evk/README_zh.md 同步更新外设支持状态(中文)
bsp/nxp/imx/imxrt/imxrt1180-nxp-evk/cm7/rtconfig.h Enable serial v2 + DMA; DMA/GPIO; linker script selection
bsp/nxp/imx/imxrt/imxrt1180-nxp-evk/cm7/board/SConscript Add QSPI flash driver source when enabled
bsp/nxp/imx/imxrt/imxrt1180-nxp-evk/cm7/board/ports/flexspi_port.h Expand QSPI enable condition
bsp/nxp/imx/imxrt/imxrt1180-nxp-evk/cm7/board/ports/flexspi_octal_flash_ops.c Formatting cleanup
bsp/nxp/imx/imxrt/imxrt1180-nxp-evk/cm7/board/MCUX_Config/pin_mux.h Add per-peripheral pin init prototypes
bsp/nxp/imx/imxrt/imxrt1180-nxp-evk/cm7/board/MCUX_Config/pin_mux.c Split pin init by peripheral; consolidate BOARD_InitPins
bsp/nxp/imx/imxrt/imxrt1180-nxp-evk/cm7/board/Kconfig Add DWT; add I2C/SPI menus; default CAN3=y; linker default change
bsp/nxp/imx/imxrt/imxrt1180-nxp-evk/cm7/board/board.c Heap init ordering change (before components init)
bsp/nxp/imx/imxrt/imxrt1180-nxp-evk/cm7/applications/mnt.c Add SD card mount hook; add logging include
bsp/nxp/imx/imxrt/imxrt1180-nxp-evk/cm7/.config Switch serial v2 + DMA; enable DMA/GPIO; linker script selection
bsp/nxp/imx/imxrt/imxrt1180-nxp-evk/cm7/.ci/attachconfig/ci.attachconfig.yml Add CI attach configs for lpuart/i2c/spi/can/rtc/dwt/sdio
bsp/nxp/imx/imxrt/imxrt1180-nxp-evk/cm33/xip/fsl_flexspi_nor_boot.c Minor formatting cleanup
bsp/nxp/imx/imxrt/imxrt1180-nxp-evk/cm33/xip/evkmimxrt1180_flexspi_nor_config.h Formatting cleanup
bsp/nxp/imx/imxrt/imxrt1180-nxp-evk/cm33/rtconfig.h Enable serial DMA; enable DMA + LPUART1 DMA config
bsp/nxp/imx/imxrt/imxrt1180-nxp-evk/cm33/board/SConscript Add QSPI flash driver source when enabled
bsp/nxp/imx/imxrt/imxrt1180-nxp-evk/cm33/board/ports/flexspi_port.h Formatting + add FlexSPI DMA request/channel defines
bsp/nxp/imx/imxrt/imxrt1180-nxp-evk/cm33/board/ports/fal_flash_port.c Formatting cleanup
bsp/nxp/imx/imxrt/imxrt1180-nxp-evk/cm33/board/ports/drv_flexspi_nor_flash.c Formatting cleanup
bsp/nxp/imx/imxrt/imxrt1180-nxp-evk/cm33/board/MCUX_Config/pin_mux.h Add per-peripheral pin init prototypes
bsp/nxp/imx/imxrt/imxrt1180-nxp-evk/cm33/board/MCUX_Config/pin_mux.c Split pin init by peripheral; consolidate BOARD_InitPins
bsp/nxp/imx/imxrt/imxrt1180-nxp-evk/cm33/board/Kconfig Add DWT; add I2C/SPI menus; default CAN3=y; linker default change
bsp/nxp/imx/imxrt/imxrt1180-nxp-evk/cm33/board/board.h Formatting cleanup
bsp/nxp/imx/imxrt/imxrt1180-nxp-evk/cm33/board/board.c Use BOARD_InitBootPins; heap init ordering change
bsp/nxp/imx/imxrt/imxrt1180-nxp-evk/cm33/applications/mnt.c Add SD card mount hook with rtdbg logging
bsp/nxp/imx/imxrt/imxrt1180-nxp-evk/cm33/.config Enable serial DMA; enable DMA + LPUART1 DMA config
bsp/nxp/imx/imxrt/imxrt1180-nxp-evk/cm33/.ci/attachconfig/ci.attachconfig.yml Add CI attach configs for lpuart/i2c/spi/can/rtc/dwt/sdio
Suppressed comments (2)

bsp/nxp/imx/imxrt/libraries/drivers/drv_rtc_bbnsm.c:134

  • [bug/错误]: Persisted epoch is truncated to 32-bit when saving to BBNSM GPR

English: bbnsm_gpr_save() writes BBNSM->GPR[GPR_IDX_EPOCH] = (uint32_t)epoch;, which drops the upper bits of epoch on 64-bit time_t builds. This breaks SET_TIME/GET_TIME correctness once the upper bits are non-zero. Please store epoch as a 64-bit value split across two GPR registers.
中文:bbnsm_gpr_save() 里 BBNSM->GPR[...] = (uint32_t)epoch; 会在 time_t 为 64 位时丢失高 32 位,导致 SET_TIME/GET_TIME 在高位非 0 时计算错误。建议将 epoch 作为 64 位值拆分到两个 GPR 寄存器保存。
bsp/nxp/imx/imxrt/libraries/drivers/drv_rtc_bbnsm.c:152

  • [bug/错误]: Restoring epoch reads only one 32-bit GPR slot

English: bbnsm_gpr_restore() reconstructs *out_epoch from a single GPR word. After saving epoch as a 64-bit split value, restore must reconstruct from high/low words to keep GET_TIME correct across warm resets.
中文:bbnsm_gpr_restore() 目前仅从一个 32 位 GPR 恢复 *out_epoch。如果按建议将 epoch 拆分为 64 位存储,这里也需要从高/低 32 位重建,才能保证 warm reset 后 GET_TIME 正确。


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment on lines +60 to +67
/* Magic value stored in BBNSM GPR[3] to detect valid warm-reset state. */
#define BBNSM_GPR_MAGIC (0xBBCC0002u)

/* BBNSM GPR array indices used by this driver. */
#define GPR_IDX_EPOCH (0u) /* Unix epoch seconds at last sync */
#define GPR_IDX_SNAP_LO (1u) /* lower 32 bits of RTC ticks at sync */
#define GPR_IDX_SNAP_HI (2u) /* upper bits of RTC ticks at sync */
#define GPR_IDX_MAGIC (3u) /* magic sentinel */
Comment on lines 11 to +13
#include <rtthread.h>
#include <rtdbg.h>
#define LOG_TAG "mnt"
Comment on lines +109 to +112
while (rt_device_find("sd0") == RT_NULL)
{
rt_thread_mdelay(1);
}
Comment on lines +121 to +124
while (rt_device_find("sd0") == RT_NULL)
{
rt_thread_mdelay(1);
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BSP: NXP Code related with NXP BSP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants