Skip to content

fix: remove unverified MariaDB helper label rule from generated defaults (v1.6.1) - #13

Merged
rdwr-egore merged 1 commit into
release/v1.6.1from
fix/v161-remove-unverified-mariadb-label-default
Oct 19, 2026
Merged

rdwr-egore merged 1 commit into
release/v1.6.1from
fix/v161-remove-unverified-mariadb-label-default

Conversation

@rdwr-egore

Copy link
Copy Markdown
Collaborator

Finding from real HA lab (read-only)

On IAD1, v1.6.0 logged that temporary MariaDB SQL syntax-check container zen_hypatia, exiting 137, was suppressed by the built-in strict dump-helper predicate (image, AutoRemove, expected mount, non-primary name, exit code), not by the configured label rule. EU1 and IAD1 both run healthy primary MariaDB with AutoRemove=false. The configured label rule is functional when a verified matching label exists, but this default is not supported by the observed helper evidence.

Changes

  • Remove the unverified MariaDB helper label default from Python DEFAULT_CONFIG, installer-generated watchdog-config.yaml, and example template.
  • Keep opt-in ignored_container_events label matching for intentionally configured/verified rules.
  • Keep the built-in strict MariaDB helper exception unchanged; primary MariaDB and unrelated failures remain monitored.
  • Preserve existing operator config on upgrade, including any old label rule (no automatic rewrites).
  • Correct development guide, customer operations guide, README and draft v1.6.1 release notes.

Tests and safety

  • 151 Python unit/regression tests passed on m920q (4 new for unlabeled helper, negative cases, opt-in labels and config defaults).
  • Installer fake-Docker tests verify new YAML omits the rule and existing YAML is untouched on upgrade.
  • Shell syntax, Python compile, git diff --check passed.
  • No application container changes or failover injection on IAD1/EU1; read-only Docker inspect/logs only.
  • Normal GitHub CI and hosted isolated Docker acceptance must run on latest commit.

Release gate

Development PR targets release/v1.6.1. Keep release PR #12 as DRAFT; do not merge it to main, tag, package or deploy v1.6.1 while more changes are planned.

@rdwr-egore
rdwr-egore merged commit f202538 into release/v1.6.1 Oct 19, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant