Repository navigation
Alpha cloud check fixes: NVIDIA revolve naming, Design-mode code writes, Mac/Linux right-drag menu - #4
Open
RandoTechNerd wants to merge 4 commits into
Open
Alpha cloud check fixes: NVIDIA revolve naming, Design-mode code writes, Mac/Linux right-drag menu#4RandoTechNerd wants to merge 4 commits into
RandoTechNerd wants to merge 4 commits into
Conversation
…of rings and clockwise profiles sweep as on Rust A face's sample point can lie anywhere round a full turn. Swinging it back on its own side of the axis put it on the mirror image of the profile, where an outer wall lies nearer an inner one: a ring cup's outer wall came out named after its inner wall, and G101 went missing from a 270-degree block. The point now goes back on the profile's side, along the axis as drawn. A part turn of a ring (profile clear of the axis) passed the stray axis line in with the closed loop and SMLib refused it (1001); it now passes the loop alone. SMLib turns about the axis line as drawn, so a clockwise profile (axis edge running the other way) swept to +120 where Rust sweeps to -120; the turn direction now follows the profile's side of the axis. test/nvidia.js compares each named face's r/z span and angle against the Rust kernel's for five revolves (5 failed before, 0 now). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MGrpCLT8AW3vBotHJbhRwf
… turns fold, sketch edits keep names, OK builds what was typed, one Ask pin loop
- press-pull (features.js pressPullText): when the size number is a const
above the call (const w = 9) and gains a digit, the compensating translate
went in one character early ("uniontranslate("); the span start now
shifts too, as boxCornerText does.
- fillet / chamfer edge pick without segments (dialogs.js nearestEdge): every
edge shares the picked face, so all tied and the first one won; distance is
now to the triangles of the face across.
- rotate / scale gizmo (features.js): shapeSpan hands over the rotate / scale
itself, so the fold check never matched and every release nested another
wrapper; a same-axis, same-pivot turn folds again, any other wraps outside.
- editing an existing sketch (sketch-model.js): on: P (a name) was written
back as "XY" and named radii / coordinates as numbers; they now go back as
written while untouched.
- feature dialogs: OK / Enter right after typing committed the previous
preview; OK now builds the fields' current text first.
- Ask about this (index.html): each pin started another requestAnimationFrame
loop; one loop now.
Tests in test/design.js for each (the edge pick, press-pull, fold and sketch
ones fail on the old code).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MGrpCLT8AW3vBotHJbhRwf
Chromium on macOS and Linux sends contextmenu as the right button goes down,
before any drag (Windows sends it on the release), so the 'moved more than
6 px: it was a pan' check always saw no movement and the shape menu opened at
the start of every right-drag pan. When contextmenu arrives with the button
still held, the menu now waits for the release and opens only if the pointer
stayed put; Windows keeps the path it had.
Found by scripts/ask-check-run.cjs in headless Chromium on Linux ('a
right-drag (pan) opens no menu' failed); it passes now.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MGrpCLT8AW3vBotHJbhRwf
…pose their overlay, sketch Finish never undoes newer code - revolve and combine dialogs passed a null body on to the text writers (a TypeError inside the async preview, so the dialog just went quiet); they now say the shape has no call in the code, as extrude / hole / fillet do. - feature dialogs made two materials per open and a PointsMaterial per hole pick and never disposed them (nor the edge line geometries on close). - sketch Finish wrote the code as it was when the sketch opened, so an edit made meanwhile was reverted without a word; it now refuses, as press-pull does, and opening a feature dialog closes an open sketch first (the sketcher took every pick, so the dialog could not get its own). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MGrpCLT8AW3vBotHJbhRwf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes from a clean Linux cloud verification of
alpha-integration(b4fec1d):npm ci,build:nvidiafrom source, the full suite, every catalog family built on both kernels (Rust and NVIDIA), and Design mode run in headless Chromium at 1600x900.NVIDIA kernel (
native/nvidia-kernel/adapter.cjs,revolve())These were already wrong on
nvidia-alpha.G101_RV. Each face's sample point is now swung back onto the profile's side of the axis.test/nvidia.jscompares each named face's r/z span and angle with Rust's on five revolves. 5 of them fail on the old code, 0 now.Design mode
const w = 9growing to 11) wroteuniontranslate(…, which is broken code (features.js).dialogs.js nearestEdge).features.js).on: Pwas written back as"XY"and named radii and coordinates as numbers. They are now kept as written until edited (sketch-model.js).dialogs.js).requestAnimationFrameloop. Now there is one loop (index.html).Right-click menu on macOS and Linux (
index.html)Chromium fires
contextmenuon press there, not on release as on Windows. The "it was a pan" check therefore never saw any movement, and every right-drag pan opened the shape menu. When the event arrives with the button still held, the menu now waits for the release and opens only if the pointer stayed put.Verified
test/nvidia.jsandtest/sketcharcs.jsagainst an addon built from source on Linux).node build-site.mjs --no-zipresolves every import.Not in this PR
Generated by Claude Code