Skip to content

Fix session lifetime in garbage collection - #77

Open
AliceKLWilliams wants to merge 1 commit into
masterfrom
bugfix/session-lifetime
Open

AliceKLWilliams wants to merge 1 commit into
masterfrom
bugfix/session-lifetime

Conversation

@AliceKLWilliams

@AliceKLWilliams AliceKLWilliams commented Nov 16, 2026 •

Copy link
Copy Markdown
Collaborator

(Thanks for sending a pull request! Please make sure you read the contribution guidelines, then fill out the blanks below.)

What does this implement/fix? Explain your changes.

As reported by a member of the Lumberjack Slack workspace, the session lifetime is being considered to be in minutes for the cookie expiration, but the garbage collection is considering it as seconds. This means that with a SESSION_LIFETIME of 1440 you would have the cookies expire after 24 hours, but the session files would be eligible for garbage collection after 24 minutes.

Does this close any currently open issues?

Closes #76

Any other comments?

I've added tests to show the value is now being considered to be in minutes rather than seconds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SESSION_LIFETIME is being read as seconds for Garbage Collection

1 participant