Repository navigation
Fix session lifetime in garbage collection - #77
Open
AliceKLWilliams wants to merge 1 commit into
Open
AliceKLWilliams wants to merge 1 commit into
AliceKLWilliams wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Thanks for sending a pull request! Please make sure you read the contribution guidelines, then fill out the blanks below.)
What does this implement/fix? Explain your changes.
As reported by a member of the Lumberjack Slack workspace, the session lifetime is being considered to be in minutes for the cookie expiration, but the garbage collection is considering it as seconds. This means that with a
SESSION_LIFETIMEof1440you would have the cookies expire after 24 hours, but the session files would be eligible for garbage collection after 24 minutes.Does this close any currently open issues?
Closes #76
Any other comments?
I've added tests to show the value is now being considered to be in minutes rather than seconds.