Repository navigation
Player's shockwave wrecks a rival on any contact - #17
Merged
Merged
Conversation
In a side contact the attacker was whoever pushed harder sideways, so a
rival rubbing into the player during a shockwave became the attacker,
and a rival never wrecks the player: nothing happened. A rival ramming
the player's rear during a shockwave was only pushed as well.
The player in a shockwave is now always the attacker, in both contact
kinds, as the README promises ("any contact wrecks a rival"). A rival's
shockwave does not change the choice, so the player still wrecks a
rival they hit hard.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Known bug from the previous cycle: during the player's shockwave, a rival that rubbed into the player harder from the side was not wrecked.
takedown(rival, player)hit the "rivals never wreck the player" rule and nothing happened. With the player in a shockwave, the player is now always the attacker.Tests
PhysicsEdgeTests:testPlayerShockwaveWrecksRivalRubbingHarderandtestPlayerShockwaveWrecksRivalRammingFromBehindfailed before the fix.testRivalShockwaveDoesNotStopPlayerTakedownguards the regression above.swift test: 64/64.🤖 Generated with Claude Code