Skip to content

security(cors): remediate js/cors-misconfiguration-for-credentials in proxy server - #16

Merged
divyanshujethi merged 1 commit into
mainfrom
fix/cors-credentials-security
Nov 7, 2026
Merged

divyanshujethi merged 1 commit into
mainfrom
fix/cors-credentials-security

Conversation

@divyanshujethi

Copy link
Copy Markdown
Collaborator

CodeQL CORS Hardening

Remediates CodeQL alerts #37 & #38 (\js/cors-misconfiguration-for-credentials):

  • Avoids setting \Access-Control-Allow-Credentials: true\ alongside dynamic or wildcard CORS origins in \src/proxy-server.ts.
  • Standardizes default fallback \Access-Control-Allow-Origin\ to *\ without credentials.

@github-actions

github-actions Bot commented Nov 7, 2026

Copy link
Copy Markdown

👋 Thanks for opening this Pull Request, @divyanshujethi!

Thank you for contributing to SkillPrism! 🚀

Here is what happens next:

  1. 🧪 Automated CI Tests: Our workflow is verifying code compilation, Biome formatting, and token benchmarks.
  2. 🔍 Code Review: A maintainer from @RitualDev-Lab will review your changes shortly.
  3. 🌟 Contributor Recognition: Once merged, you'll be featured on our contributors list!

💡 Tip: Make sure your commits follow Conventional Commits and tests pass locally (pnpm test).

@divyanshujethi
divyanshujethi merged commit 7b0613f into main Nov 7, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant