Repository navigation
feat/rework-req-object-algs - #127
Merged
Merged
Conversation
patchandthat
requested review from
JoStevensRSK,
jhbritton-RSK and
joe-harvey-rsk
October 20, 2026 15:39
joe-harvey-rsk
approved these changes
Oct 20, 2026
Makes the addition of request_object_signing_alg_values_supported a non-breaking change, to allow for a minor release. The default values will be updated during the next major release.
patchandthat
force-pushed
the
feat/request-obj-algs
branch
from
October 20, 2026 16:05
d48c28c to
6a0cacd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Makes the addition of request_object_signing_alg_values_supported a non-breaking change, to allow for a minor release.
The default values will be updated during the next major release.
Type of change
Does this PR introduce a breaking change?
Makes a previous change non-breaking and backwards compatible.
Testing
Test updated, manually verified
LLM Usage
Please describe where and how you have used LLM tooling in relation to these changes.
Note: We want all code changes in the shippable nuget packages to be human authored. LLM usage elsewhere is acceptable, you are expected to thoroughly scrutinise any generated content.
N/A