Repository navigation
ssh-encoding: non-negative Mpint and other OpenSSH alignment - #622
Merged
Merged
Conversation
tarcieri
force-pushed
the
ssh-encoding/non-negative-mpint
branch
5 times, most recently
from
November 10, 2026 22:00
163864a to
231399e
Compare
Restrict `Mpint` to non-negative integers and enforce the 16384-bit cap across every construction path. Match OpenSSH's rejection of negative encodings and acceptance of redundant leading zeros, checking the wire length before normalization and always emitting canonical encodings. Stores unsigned magnitudes internally and exposes them through `from_bytes` and `as_bytes`, removing the positive-specific APIs. Makes conversions from `crypto_bigint::Uint` fallible and conversions back infallible. Replaces derived bytewise ordering with numeric ordering using `ctutils`, and preserve canonical zero after zeroization. Updates `ssh-key` callers, including parsing PPK Ed25519 seeds as raw byte strings instead of mpints so their high bits and leading zeros are preserved.
tarcieri
force-pushed
the
ssh-encoding/non-negative-mpint
branch
from
November 10, 2026 22:16
231399e to
edf9bc6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restrict
Mpintto non-negative integers and enforce the 16384-bit cap across every construction path. Match OpenSSH's rejection of negative encodings and acceptance of redundant leading zeros, checking the wire length before normalization and always emitting canonical encodings.Stores unsigned magnitudes internally and exposes them through
from_bytesandas_bytes, removing the positive-specific APIs. Makes conversions fromcrypto_bigint::Uintfallible and conversions back infallible. Replaces derived bytewise ordering with numeric ordering usingctutils, and preserve canonical zero after zeroization.Updates
ssh-keycallers, including parsing PPK Ed25519 seeds as raw byte strings instead of mpints so their high bits and leading zeros are preserved.