Repository navigation
Keep valid packets when another source has timed out - #81
Merged
stewartadam merged 1 commit intoNov 12, 2026
Merged
Conversation
check_seq_number ran the global timeout check with announce_timeout set, so a UniverseTimeout for any source was returned in place of the packet being checked and that packet was lost. Timeouts are already reported by recv before each read, so only prune here when they aren't announced. A timed out entry that hasn't been removed yet is now treated as a new universe for that source, so a restarted source isn't rejected as out of sequence. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KzaQVPkrkczgX2g7wGkip5
stewartadam
deleted the
claude/project-thread-0t11p6-1-keep-packet-on-timeout
branch
November 12, 2026 09:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
With
announce_timeoutenabled,check_seq_numberran the global timeout check and returned the firstUniverseTimeoutit found. That error replaced the result for the packet being checked, so a valid packet from source A was dropped whenever some other source B had timed out.Fix
SacnReceiver::recvalready runs the timeout check (and announces timeouts) before every socket read.check_seq_numbernow only prunes timed-out entries itself when timeouts are not being announced.Tests
Two unit tests in
receive.rs:recvto report;cargo test --libpasses.This touches the same function as the fix for the inverted
breakincheck_timeouts. That fix changes a different part of the file, so the two shouldn't conflict.