Skip to content

[Lane 6 · review] GroupNormalization — review GroupNormalization #1383

Open

Description

@michalharakal

Sub-issue of #1379 ([Feature]: GroupNormalization forward pass (groupNorm {} DSL currently crashes)).

Lane: 6 · Review
Skill needed: DARC review. Must not be the implementer of Lane 2.
Size: xs (under 1 hour)
Blocked by: #1381

What to do

  1. Wait until the other lanes of this feature are merged or in review.
  2. Check the forward pass against the parent issue's Document/Assess sections and the PyTorch reference.
  3. Run the tests named in each lane's acceptance list yourself.
  4. Confirm the coverage matrix (docs/modules/ROOT/pages/reference/ops-status-matrix.adoc) shows ✅ where the lanes claim it and no @NotImplemented was left behind.

Acceptance

  • Review notes posted on the parent issue

Notes

If something here turns out to be wrong or much bigger than the size label, comment on this issue or open a specific bug instead of blocking the parent.

Coverage matrix: docs/modules/ROOT/pages/reference/ops-status-matrix.adoc · How lanes work: Issue taxonomy

Metadata

Metadata

Assignees

No one assigned

    Labels

    assessmentAssessment task (DARC: A)size:xsUnder 1 hourskill:reviewDARC review; must not be the task's implementersub-issueSub-issue of a tracking issue

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions