You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Lane 2 · kotlin-core] StableHLO coverage — lower elu, leakyRelu to StableHLO #1390
Sub-issue of #1389 ([Feature]: StableHLO converter coverage — lower every TensorOps op).
Lane: 2 · Kotlin core Skill needed: Kotlin; reading a little MLIR text. No SKaiNET runtime or kernel knowledge needed — converters only emit text. Size: xs (under 1 hour) Blocked by: nothing
What to do
Open skainet-compile/skainet-compile-hlo/src/commonMain/kotlin/sk/ainet/compile/hlo/converters/ActivationOperationsConverter.kt and find an op it already lowers that is similar.
Add elu + leakyRelu to its supportedOperations and emit: stablehlo.select(x > 0, x, alpha * (exp(x) - 1)) for elu and select(x > 0, x, alpha * x) for leakyRelu; read alpha from the node parameters the same way other activations read theirs.
Add a one-node export test next to the converter's existing tests in skainet-compile/skainet-compile-hlo/src/commonTest (copy one of its tests).
Run ./gradlew :skainet-compile:skainet-compile-hlo:jvmTest, then regenerate the matrix: ./gradlew :skainet-compile:skainet-compile-hlo:jvmTest --tests '*HloCoverageDumpTest' :skainet-compile:skainet-compile-dag:jvmTest --tests '*BackwardCoverageDumpTest' generateDocs and commit the changed docs/modules/ROOT/pages/reference/ files.
Acceptance
StableHLO column shows ✅ for elu + leakyRelu
Export test passes
Result reported back on the parent issue
Notes
If something here turns out to be wrong or much bigger than the size label, comment on this issue or open a specific bug instead of blocking the parent.
Activity