You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Sub-issue of #1389 ([Feature]: StableHLO converter coverage — lower every TensorOps op).
Lane: 2 · Kotlin core Skill needed: Kotlin; reading a little MLIR text. No SKaiNET runtime or kernel knowledge needed — converters only emit text. Size: s (a few hours) Blocked by: nothing
What to do
Open skainet-compile/skainet-compile-hlo/src/commonMain/kotlin/sk/ainet/compile/hlo/converters/ActivationOperationsConverter.kt and find an op it already lowers that is similar.
Add logSoftmax to its supportedOperations and emit: the numerically stable form x - max - log(sum(exp(x - max))) along the op's dim — reuse the reduce structure softmax already emits.
Add a one-node export test next to the converter's existing tests in skainet-compile/skainet-compile-hlo/src/commonTest (copy one of its tests).
Run ./gradlew :skainet-compile:skainet-compile-hlo:jvmTest, then regenerate the matrix: ./gradlew :skainet-compile:skainet-compile-hlo:jvmTest --tests '*HloCoverageDumpTest' :skainet-compile:skainet-compile-dag:jvmTest --tests '*BackwardCoverageDumpTest' generateDocs and commit the changed docs/modules/ROOT/pages/reference/ files.
Acceptance
StableHLO column shows ✅ for logSoftmax
Export test passes
Result reported back on the parent issue
Notes
If something here turns out to be wrong or much bigger than the size label, comment on this issue or open a specific bug instead of blocking the parent.
Activity