Fix stale IntervalUnit docstring to match enum members - #5957
Open
maupatel wants to merge 2 commits into
Open
Conversation
Signed-off-by: Maulik Patel <21225464+maupatel@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
IntervalUnitclass docstring insqlmesh/core/node.pyis out of date with the enum defined directly below it. It states:But the enum actually has 7 members and no
MINUTE:YEAR,MONTH,DAY,HOUR,HALF_HOUR,QUARTER_HOUR,FIVE_MINUTE. The sub-hour granularities were added after the docstring was written. This updates the docstring to match the code (and the publicmodel_configurationdocs, which already list all seven values).Documentation-only; no behavior change.