Repository navigation
Conversation
Signed-off-by: Michael Day <mdaytn@gmail.com>
Signed-off-by: Michael Day <mdaytn@gmail.com>
Signed-off-by: Michael Day <mdaytn@gmail.com>
mday-io
marked this pull request as ready for review
October 19, 2026 12:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Why
SQLMesh sources can use
catalog.schema.tablenames, but ClickHouseDataLakeCatalogexposes them asdatabase."schema.table". Without a mapping, SQLMesh cannot render these source references correctly for ClickHouse reads and model materialization.How
Add
datalake_catalog_mappingto the ClickHouse connection configuration. For example,{lake: iceberg}renderslake.analytics.eventsasiceberg."analytics.events". The mapping defaults to empty and applies only to parsed query sources. Raw SQL strings and INSERT targets remain unchanged.Direct reads preserve unmapped catalogs. Materialization rejects unknown source catalogs when a mapping or injected virtual catalog is active. The existing restriction on cross-catalog view creation remains in place.
Includes configuration documentation and a dedicated ClickHouse, Iceberg REST, and MinIO integration fixture in the PR Docker CI matrix.
Test Plan
make stylepassed all four hooks on the current revision.pytest -n 0 tests/core/engine_adapter/test_clickhouse.pypassed 107 tests, including exact raw-SQL pass-through and unchanged INSERT-target checks.make fast-testwith 2,933 passed and 13 skipped, andmake doc-testwith 29 passed.Checklist
make styleand fixed any issuesmake fast-test)git commit -s) per the DCO