Repository navigation
feat: amount search, trip transaction search, transfer account detail, IBAN rule condition - #2
Merged
Conversation
…, IBAN rule condition - search transactions by amount on the Transactions page and inside a trip - trip cards say how far over what was put in a trip is - transfer rows show the accounts they joined (last four of the IBAN) - rules can match the other account's IBAN and now outrank transfer detection Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why the rule order changed: without it an IBAN rule could never turn a credit to your savings account into Savings, because transfer detection ran first and double-booking re-filed it afterwards.
Evidence
12.50found nothing; a savings credit stayed hidden as Transfer with no way to tell which account it joined.After:
npm testpasses, API 228 and web 236.npm run checkis clean.Not checked by eye in the running app.
Merge Danger
Door: two-way
No schema or data migration. A rule's IBAN lives in the already-encrypted
matchJSON, and older rules still work.Blast Radius: categorizing
Any rule of yours now outranks transfer detection, so a broad rule (say a payee that also appears on a transfer) can turn a Transfer into a counted expense or income. The paired incoming side of a transfer stays excluded from income.
🤖 Generated with Claude Code