Skip to content

tests/virtual_disk: build a non-empty .vmdk fixture (fixes target on HyperCore 9.8.x) #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ddemlow wants to merge 2 commits into
base: main
Choose a base branch
from
Open

tests/virtual_disk: build a non-empty .vmdk fixture (fixes target on HyperCore 9.8.x) #378

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f94671
tests/virtual_disk: build a non-empty .vmdk fixture
ddemlow Aug 14, 2026
023e078
tests/virtual_disk: soften the fixture comment to match what is estab…
ddemlow Aug 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 23 additions & 3 deletions tests/integration/targets/virtual_disk/tasks/01_supported.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,29 @@
# Update: maybe `qemu-img convert -c` compress option is a problem
mkfs.ext4 xlab-ci-test-VD.raw
qemu-img convert -O qcow2 xlab-ci-test-VD.raw xlab-ci-test-VD.qcow2
# Empty vmdk image seems to be OK
# But non-empty image with ext4 filesystem is a problem.
qemu-img create -f vmdk xlab-ci-test-VD.vmdk 10M
# The .vmdk must not be completely empty either.
#
# It used to be built with a bare `qemu-img create -f vmdk ... 10M`, which produces a
# 65536-byte file with nothing allocated. On HyperCore 9.8.2.226476 that upload fails with
# HTTP 502 and this target cannot pass; 9.7.6.226153 and 9.7.8.226633 accept it, so the
# behaviour is new in 9.8.x.
#
# The exact trigger is NOT fully characterised. A file-size threshold around 64 KiB
# reproduces on one cluster but not on another, so the rule is not stated here as though it
# were settled. Investigation of the underlying product behaviour is ongoing separately.
# This change only stops the test depending on a case we do not yet understand.
#
# Trade-off worth being explicit about: the suite consequently no longer exercises
# minimally-allocated images. If that case matters to users, it needs its own coverage once
# the product behaviour is understood.
#
# A few KiB of data is enough to cross that boundary. Deliberately NOT an ext4 image: the
# older comment here warned that a non-empty ext4 filesystem inside a vmdk was itself a
# problem (never re-verified on 9.5/9.6, so worth continuing to avoid), and this keeps the
# .vmdk independent of mkfs.ext4.
qemu-img create -f raw xlab-ci-test-VD-vmdk-src.raw 10M
dd if=/dev/urandom of=xlab-ci-test-VD-vmdk-src.raw bs=4096 count=1 conv=notrunc 2>/dev/null
qemu-img convert -O vmdk xlab-ci-test-VD-vmdk-src.raw xlab-ci-test-VD.vmdk

# ----------------------------------Job------------------------------------------------------------------------
- name: Upload virtual disk file .qcow2
Expand Down
Loading