Repository navigation
fix(proxy): move URL credentials out of server and accept local proxy hosts - #1170
Open
alkaz-nodemaven wants to merge 1 commit into
Open
alkaz-nodemaven wants to merge 1 commit into
alkaz-nodemaven wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two problems with
loader_kwargs["proxy"]:http://user:pass@host:8080) stay inserver, and Playwright ignores them there, so the proxy answers 407. They're now moved tousername/password(percent-decoded). Ifusername/passwordare set explicitly, those win.localhost:8888, a Docker service likehttp://proxy:8080, or IPv6 fail withunknown proxy server type, because the host check only allows IPv4 or a domain with a TLD. Any host with a port is accepted now; a bareunknownwith no port is still rejected, so the existing test still holds.Error messages no longer include the password either.
Tests added in
tests/utils/test_proxy_rotation.py; all fail onpre/betaand pass with the change.test_search_proxy_servers_successhits free-proxy-list.net and fails in my environment both before and after, so it's unrelated.