Repository navigation
fix: include user question in chunk extraction prompts - #1171
Open
AmeyaBadve wants to merge 2 commits into
Open
AmeyaBadve wants to merge 2 commits into
AmeyaBadve wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Markdown and HTML chunk extraction prompts omit the user's question, even though the standard
GenerateAnswerNodepasses it as an input variable.Consequently, the LLM processes webpage content without knowing what information the user requested, potentially returning incorrect or irrelevant results.
The K-level answer node also uses these shared templates but previously passed the user prompt through
format_instructionsrather thanquestion. Adding{question}to the templates therefore requires updating the K-level node as well.Fix
USER QUESTION: {question}in both Markdown and HTML chunk extraction templates.GenerateAnswerNodeKLevelto pass the user prompt throughquestion.format_instructionsin the K-level node.Testing
3 passed).